Improve the installation of -dev and -BETA versions #185

javiereguiluz · 2015-09-11T09:34:18Z

This finishes #159, which is related to #144 and #143.

The new behavior of the installer:

When installing a regular Symfony version, nothing changes from the previous installer.
When you install a beta version, you see a warning message:

When you try to install a dev version, you get a better error message and a link to the article that will solve your problem:

javiereguiluz · 2015-09-15T11:39:06Z

I'd like to merge this change soon because I want to test it well before we enter into the most intense release period in Symfony history (including a major version change). Please add any comment or review that you may have. Thanks!

xabbuh · 2015-09-23T14:17:39Z

src/Symfony/Installer/NewCommand.php

            return $this;
        }

        // validate semver syntax
-        if (!preg_match('/^2\.\d(?:\.\d{1,2})?$/', $this->version)) {
-            throw new \RuntimeException('The Symfony version should be 2.N or 2.N.M, where N = 0..9 and M = 0..99');
+        if (!preg_match('/^2\.\d(?:\.\d{1,2})?(-(dev|BETA)\d*)?$/', $this->version)) {


Numbers don't make sense after dev, do they? And what about lowercased beta strings?

In 9b3cdc1 we no longer allow numbers after the dev version.

Regarding the BETA uppercase/lowercase issue, I thought about that but I decided to leave it untouched. If we silently fix beta as BETA, we should also fix DEV to dev. Honestly, I don't know if this is right for user experience or it's bad because we are supporting wrong version names.

Composer actually makes no difference here. So we would be consistent with its behaviour.

xabbuh · 2015-09-23T14:20:34Z

@javiereguiluz SO we can now download archives of all beta versions? Does this include all beta versions that have been released in the past?

javiereguiluz · 2015-09-23T14:37:14Z

@xabbuh yes, we can download any past beta package. For example:

$ symfony new my_project 2.6.0-BETA1

… versions

weaverryan · 2015-09-23T16:05:26Z

👍 as is - it'll be great to be able to show people how to create a new beta project for testing when the beta's are released.

…ate 'BETA1' from 'beta1'

javiereguiluz · 2015-09-24T16:15:44Z

After @xabbuh's comments, I can confirm that Composer is case insensitive at least on Mac OS. These commands result in the same installation:

$ composer create-project symfony/framework-standard-edition my_project 2.7.0-BETA1
$ composer create-project symfony/framework-standard-edition my_project 2.7.0-beta1

That's why in 31765ca I've changed all dev and BETA comparisons to case insentivity. I'll merge this last version unless someone tells me not to. Thanks!

stof · 2015-09-24T17:28:29Z

I can confirm that Composer is case insensitive at least on Mac OS

it is on all systems. It normalizes the case of stability specifiers: https://github.com/composer/composer/blob/15face5432d7b7334db6ac69fac0190971cafa6e/src/Composer/Package/Version/VersionParser.php#L49

stof · 2015-09-24T17:29:12Z

src/Symfony/Installer/NewCommand.php

            return $this;
        }

        // validate semver syntax
-        if (!preg_match('/^2\.\d(?:\.\d{1,2})?$/', $this->version)) {
-            throw new \RuntimeException('The Symfony version should be 2.N or 2.N.M, where N = 0..9 and M = 0..99');
+        if (!preg_match('/^2\.\d(?:\.\d{1,2})?(-(dev|BETA\d*))?$/i', $this->version)) {


you should use non-capturing groups here

I've changed it by this: '/^2\.\d(?:\.\d{1,2})?(?:-(?:dev|BETA\d*))?$/i'

stof · 2015-09-24T17:29:41Z

@javiereguiluz what about RC versions ?

stof · 2015-09-24T17:31:14Z

@javiereguiluz shouldn't you normalize the case of BETA for the generated archive URL though ? Or is it case insensitive on the server too ?

javiereguiluz · 2015-09-24T17:46:11Z

In b26b217 I've added support for RC versions and I've normalized the version names before downloading them from the server.

xabbuh · 2015-09-25T11:41:55Z

src/Symfony/Installer/NewCommand.php

            return $this;
        }

        // validate semver syntax
-        if (!preg_match('/^2\.\d(?:\.\d{1,2})?$/', $this->version)) {
-            throw new \RuntimeException('The Symfony version should be 2.N or 2.N.M, where N = 0..9 and M = 0..99');
+        if (!preg_match('/^2\.\d(?:\.\d{1,2})?(?:-(?:dev|BETA\d*|RC\d*))?$/i', $this->version)) {


You could now pass a patch version and a dev suffix. I think both parts should be exclusive.

dev suffixes are all rejected just later, so this is not a big deal IMO

Yeah, but this does not only apply to the -dev suffix but also to -BETA and -RC.

and beta versions are named 2.1.0-beta, not 2.1-beta

Hm indeed, then we can move that part of the regex.

I've changed this regular expression by:

if (!preg_match('/^2\.\d(?:\.\d{1,2})?|2\.\d(?:-(?:dev|BETA\d*|RC\d*))$/i', $this->version))

Please review it. Thanks!

Did you forget to push the changes?

I've pushed it .... and then reverted it. The correct beta version is x.y.z-BETAn, not x.y-BETAn

There would still be some versions that pass the regex but are not valid. Though actually the installer will fail with a meaningful message anyway later on. So I think it's okay if we just stick with this solution.

xabbuh · 2015-09-27T14:48:17Z

tests/Symfony/Installer/Tests/IntegrationTest.php

@@ -106,6 +106,12 @@ public function provideSymfonyInstallationData()
                '/.*Symfony 2\.5\.6 was successfully installed.*/',
                '/Symfony version 2\.5\.6 - app\/dev\/debug/',
            ),
+
+            array(
+                '2.7-BETA1',


This version should fail while 2.7.0-BETA1 should succeed (I think it would be good to have tests for both versions).

Indeed. Fixed. Thanks.

xabbuh · 2015-09-27T15:47:07Z

tests/Symfony/Installer/Tests/IntegrationTest.php

+            array(
+                '2.7.0-BETA1',
+                '/.*Symfony 2\.7\.0\-BETA1 was successfully installed.*/',
+                '/Symfony version 2\.7\-BETA1 - app\/dev\/debug/',


This seems to need an update too, doesn't it?

I'm trying to do things fast ... but I do everything wrong :( Thanks for reviweing this!

xabbuh · 2015-09-28T06:21:29Z

👍

javiereguiluz · 2015-09-28T06:22:01Z

@xabbuh thanks for the review. I'm gonna merge it now, so we have time to test it well before the 2.8.0-BETA1 release. Thanks!

…oni, javiereguiluz) This PR was merged into the 1.0-dev branch. Discussion ---------- Improve the installation of -dev and -BETA versions This finishes #159, which is related to #144 and #143. The new behavior of the installer: 1) When installing a regular Symfony version, nothing changes from the previous installer. 2) When you install a `beta` version, you see a warning message: ![symfony-unstable-warning](https://cloud.githubusercontent.com/assets/73419/9811676/f14b6d02-5878-11e5-9220-301fcb671c8c.png) 3) When you try to install a `dev` version, you get a better error message and a link to the article that will solve your problem: ![symfony-dev-version](https://cloud.githubusercontent.com/assets/73419/9811642/c0bdc194-5878-11e5-9ee8-9af5e194f80b.png) Commits ------- 6751701 Fixed again one test 3ea393a Fixed one test f45a29a Fixed again the version parser regexp 165813c Added new tests for BETA and RC versions 9e41335 Updated the version parser regular expression b26b217 Added support for RC versions and normalized version names 31765ca Made comparisons case insensitive because Composer doesn't differentiate 'BETA1' from 'beta1' 9b3cdc1 The trailing number is only available for BETA versions not for 'dev' versions d03938f Fixed syntax issues d67b4ad Improved the error message for "-dev" versions 4c26d2b Warn the user when downloading an unstable version 94a1f98 Simplified the new feature a bit d58812a Installation dev/beta versions (143)

94noni and others added 4 commits September 11, 2015 11:05

Installation dev/beta versions (143)

d58812a

Simplified the new feature a bit

94a1f98

Warn the user when downloading an unstable version

4c26d2b

Improved the error message for "-dev" versions

d67b4ad

javiereguiluz added the feature label Sep 11, 2015

This was referenced Sep 11, 2015

Installation dev/beta versions (143) #159

Closed

Detect dev/beta versions and provide appropriate instruction #144

Closed

Fixed syntax issues

d03938f

javiereguiluz added the NEEDS COMMENTS label Sep 15, 2015

xabbuh reviewed Sep 23, 2015
View reviewed changes

The trailing number is only available for BETA versions not for 'dev'…

9b3cdc1

… versions

javiereguiluz removed the NEEDS COMMENTS label Sep 23, 2015

Made comparisons case insensitive because Composer doesn't differenti…

31765ca

…ate 'BETA1' from 'beta1'

javiereguiluz added the FINISHED label Sep 24, 2015

stof reviewed Sep 24, 2015
View reviewed changes

Added support for RC versions and normalized version names

b26b217

xabbuh reviewed Sep 25, 2015
View reviewed changes

javiereguiluz added 3 commits September 26, 2015 10:41

Updated the version parser regular expression

9e41335

Added new tests for BETA and RC versions

165813c

Fixed again the version parser regexp

f45a29a

xabbuh reviewed Sep 27, 2015
View reviewed changes

Fixed one test

3ea393a

xabbuh reviewed Sep 27, 2015
View reviewed changes

Fixed again one test

6751701

javiereguiluz merged commit 6751701 into symfony:master Sep 28, 2015

xabbuh mentioned this pull request Sep 28, 2015

Beta and RC versions handling in the installer symfony/symfony-docs#5734

Closed

Improve the installation of -dev and -BETA versions #185

Improve the installation of -dev and -BETA versions #185

Uh oh!

Conversation

javiereguiluz commented Sep 11, 2015

Uh oh!

javiereguiluz commented Sep 15, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Sep 23, 2015

Uh oh!

javiereguiluz commented Sep 23, 2015

Uh oh!

weaverryan commented Sep 23, 2015

Uh oh!

javiereguiluz commented Sep 24, 2015

Uh oh!

stof commented Sep 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stof commented Sep 24, 2015

Uh oh!

stof commented Sep 24, 2015

Uh oh!

javiereguiluz commented Sep 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Sep 28, 2015

Uh oh!

javiereguiluz commented Sep 28, 2015

Uh oh!

Uh oh!