ENH: Automatic generation of template citations #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
commented
Feb 27, 2020
Member
|
Sounds like a reasonable extra to me
…On Thu, Feb 27, 2020, 08:44 Mathias Goncalves ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In setup.cfg
<#35 (comment)>
:
> @@ -23,6 +23,7 @@ install_requires =
pybids >= 0.9.2
requests
tqdm
+ doi2bib
Do we want to have this in the base installation or as an extra?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#35?email_source=notifications&email_token=AAESDRQOQWPPSO5RP3ASC5TRE7UWBA5CNFSM4K46WYE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXG7J5I#pullrequestreview-365819125>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESDRUOFYETPFZTSEDQKULRE7UWBANCNFSM4K46WYEQ>
.
|
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
+ Coverage 67.88% 85.44% +17.55%
===========================================
Files 5 5
Lines 137 158 +21
===========================================
+ Hits 93 135 +42
+ Misses 44 23 -21
Continue to review full report at Codecov.
|
084f77b to
fb71c7a
Compare
Contributor
Author
|
Okay - this is ready for review |
oesteban
reviewed
Mar 3, 2020
Member
oesteban
left a comment
There was a problem hiding this comment.
This is a very solid starting point to nontrivial problem - thanks much!
Contributor
Author
|
Once we drop 3.5 fully (#36), things should be working. |
Co-Authored-By: Oscar Esteban <[email protected]>
oesteban
reviewed
Mar 4, 2020
bb078ec to
b4d1290
Compare
Contributor
Author
|
@oesteban did the skeleton change between the last 2 commits? |
Member
|
I was testing, so that's possible. |
Member
|
I would get #39 merged first to avoid this kind of problems |
oesteban
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept of #33
This requires a few changes to existing template descriptions:
ReferencesAndLinkstype from list to dictionary to facilitate extractionHowToAcknowledgefields to include curly brackets with Reference IDs