Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature Request] Support dynamic workflows, activities, signals, and queries #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cretz opened this issue Jan 5, 2023 · 0 comments · Fixed by #346
Closed

[Feature Request] Support dynamic workflows, activities, signals, and queries #242

cretz opened this issue Jan 5, 2023 · 0 comments · Fixed by #346
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 5, 2023

Is your feature request related to a problem? Please describe.

Need opt-in catch-alls for workflows, activities, signals, and queries.

Describe the solution you'd like

Should be able to register only one workflow as "dynamic" and it is given the name as a string as the first arg, then *args: Payload as second arg. This means we also need to provide the users of a workflow access to their payload converter to convert those.

Need to do the same for activity.

For signal and query handlers, we already have dynamic=True, but we foolishly allow already-decoded args. Ideally, we would change to require payloads. But since that may be a breaking change, we should just args hinted as payloads pass through unconverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant