Add Google Cloud PubSub support #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb443c8 to
34d2289
Compare
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
to address the issue in grpc where `-D_GLIBCXX_USE_CXX11_ABI=0` is not passed automatically Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
/cc @terrytangyuan This PR is also ready. The build is enabled in macOS and Linux. The test is done in Linux (skipped on macOS for now as there seems to be a bug in google SDK's macOS support?). Please take a look |
terrytangyuan
approved these changes
Feb 28, 2019
Member
terrytangyuan
left a comment
There was a problem hiding this comment.
Looks great! Though I wonder where we should keep the compatibility matrix, e.g. some ops don't work on certain system, etc.
| echo Wait 15 secs until kafka is up and running | ||
| # Note somehow it takes longer time in Darwin | ||
| sleep 15 | ||
| sleep 5 |
Member
There was a problem hiding this comment.
This doesn't take longer anymore in Darwin?
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
Add Google Cloud PubSub support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to support Google Cloud PubSub, which is a vendor specific cloud streaming platform on GCP. The concept of PubSub is similar to Apache Kafka.
Google Cloud PubSub does not have a C++ SDK, though it has a gRPC endpoint so this implementation is based on gRPC.
This implementation is tested with google cloud pubsub emulator for now. Will need additional effort to bring GCP IAM support in place.
This PR fixes #31.