Thanks to visit codestin.com
Credit goes to github.com

Skip to content

R package CRAN submission preparations #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yongtang merged 21 commits into from
Jan 15, 2019
Merged

R package CRAN submission preparations #52

yongtang merged 21 commits into from
Jan 15, 2019

Conversation

@terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jan 12, 2019 •
edited
Loading

This is for #6 and before we submit for release to CRAN for #18, including the following:

  • Added test cases and examples for all existing dataset ops
  • Added parquet_dataset(), webp_dataset(), and video_dataset()
  • Removed unnecessary dependencies and use cache on Travis to speed up
  • Simplified testing logic and safer/validated package loading
  • Fixed all CRAN check warnings/errors/notes that need to be addressed before release

cc: @yongtang @gdequeiroz

@terrytangyuan
Remove unnecessary dependencies
f22121c
@terrytangyuan
Simplify tests skipping logic
598a2eb
@terrytangyuan
Add tests for kafka and ignite datasets
f1d8291
@terrytangyuan
Added parquet_dataset()
b989d03
@terrytangyuan
Check whether tensorflow_io is installed before loading
cec81ba
@terrytangyuan
Configure and install Python deps
023ba8b
@terrytangyuan
Added webp_dataset()
ce15fbf
@terrytangyuan
Upgrade pip and fix permission on Travis
49a8294
@terrytangyuan
Try fix Travis issue
b128bd1
@terrytangyuan
Build/install tensorflow-io whl and use specific CRAN mirror
9216e19
@terrytangyuan
Switch to use tensorflow-io on PyPI for now
64f34d4
@terrytangyuan
Use pip and rlib cache on Travis
75395fb
@terrytangyuan
Reexports dataset_properties methods
4499ebf
@terrytangyuan
Reexports iterators methods
9d58128
@terrytangyuan
Update example and tests to iterate batches
5430c0b
@terrytangyuan
Add example sections in roxygen docs
a73ecd0
@terrytangyuan
Added neccessary files and fixed warnings for check()
d2a1992
@terrytangyuan
Fix conflicts
c936a7f
@terrytangyuan
Merge branch 'master' into r-prepare-release
203821d
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jan 13, 2019 •
edited
Loading

All issues have been fixed. This is ready for review. I’ll add other dataset op wrappers (#48 #36 if they ever make it before next release) in a follow-up PR.

@terrytangyuan terrytangyuan changed the title [WIP] R package CRAN submission preparations R package CRAN submission preparations Jan 13, 2019
@yongtang
Copy link
Member

yongtang commented Jan 14, 2019

Overall looks good! I will take another look tomorrow. For 0.1.0 release with R CRAN, I think bring it with tensorflow-io 0.1.0 PyPI package would be good enough. We could have another release after we are in R CRAN first.

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jan 14, 2019

@yongtang Sure, I can go ahead and submit to CRAN once this PR is merged. One thing to note though is that #34 is merged after we already released v0.1.0 to PyPI so Ignite will not be supported unless a new version is released.

@yongtang
Copy link
Member

yongtang commented Jan 15, 2019

Tested locally and works. Thanks!

yongtang
yongtang approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang yongtang merged commit d94dd2b into tensorflow:master Jan 15, 2019
@terrytangyuan terrytangyuan deleted the r-prepare-release branch January 15, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongtang yongtang yongtang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terrytangyuan @yongtang