Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[v4][no-debug] Crash with Cannot read property 'name' of null #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
epmatsw opened this issue Mar 29, 2021 · 3 comments
Closed

[v4][no-debug] Crash with Cannot read property 'name' of null #306

epmatsw opened this issue Mar 29, 2021 · 3 comments
Assignees
@Belco90
Labels
released on @beta released
Milestone
v4

Comments

@epmatsw
Copy link

epmatsw commented Mar 29, 2021

We've got some code that looks like:

thing.method.lastCall.args[0]();

This is causing a crash in the CallExpression handler in no-debug. In this case, callExpressionIdentifier is null. I suspect that getDeepestIdentifierNode doesn't handle array accessors correctly, and it also can explicitly return null.
@Belco90
Copy link
Member

Belco90 commented Mar 29, 2021

Hey @epmatsw, thank you very much for your feedback on v4! This is a tricky one, but thank you very much for the detailed explanation. Added to the list of things to fix, I think this will be related to #305

@Belco90 Belco90 self-assigned this Mar 29, 2021
@Belco90 Belco90 mentioned this issue Apr 2, 2021
Merged
Belco90 added a commit that referenced this issue Apr 3, 2021
@Belco90
Merge pull request #309 from testing-library/306_null-identifiers
eaca948 
fix: guard against null identifier nodes
Closes #305
Closes #306
@github-actions
Copy link

github-actions bot commented Apr 3, 2021

🎉 This issue has been resolved in version 4.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90 Belco90 closed this as completed Apr 3, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added this to the v4 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belco90 Belco90

Labels
released on @beta released
Projects
None yet
Milestone
v4
Development

No branches or pull requests
3 participants
@epmatsw @Belco90 @MichaelDeBoey