fix: guard against null identifier nodes #309
Conversation
| branches: 90, | ||
| functions: 90, | ||
| lines: 90, |
There was a problem hiding this comment.
I've dropped the coverage threshold a bit since I prefer to guard against null nodes everywhere even if there is no possible code for it. We'll see what I do with this after releasing v4.
| @@ -83,13 +89,22 @@ export default createTestingLibraryRule<Options, MessageIds>({ | |||
| }, | |||
| CallExpression(node) { | |||
| const callExpressionIdentifier = getDeepestIdentifierNode(node); | |||
There was a problem hiding this comment.
@timdeschryver This is really weird: getDeepestIdentifierNode (and some other utils for finding identifiers) are typed as returning TSESTree.Identifier | null. However, TS is assuming they always returning TSESTree.Identifier but never null:
Then, if I update the function to return '' instead of return null and update the returned type to TSESTree.Identifier | string, TS starts complaining about returned value saved in all these rules might not be an Identifier. Is this a bug on TS? Am I missing something else? I don't get why it always assumes null won't be returned.
There was a problem hiding this comment.
I suspect turning on strictNullChecks in the tsconfig would fix that.
There was a problem hiding this comment.
Oh wow... TIL...
@epmatsw is right, you'll have to turn the strict mode on.
I would encourage to turn on strict mode though, not just strict null checks.
There was a problem hiding this comment.
Aah damn! I thought we had strict enabled, but anyway I didn't expect those nullable values to be silent. I'm gonna enable strict mode and fix all corresponding issues then. Thanks guys.
| @@ -139,6 +139,10 @@ ruleTester.run(RULE_NAME, rule, { | |||
| debug() | |||
| `, | |||
| }, | |||
|
|
|||
| `// cover edge case for https://github.com/testing-library/eslint-plugin-testing-library/issues/306 | |||
| thing.method.lastCall.args[0](); | |||
There was a problem hiding this comment.
Test for issue mentioned by @epmatsw
|
Ok, so I've enabled TS |
|
Hmm. Maybe throw an |
That fixed almost all of them. The problem is the Now I got some tests failing, I'm looking into them. |
|
Everything ok now, merging to test it on beta 3. |
|
🎉 This PR is included in version 4.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #305. Closes #306.