Hey @xyng,
Thanks for your PR, it's a good start!

Webonyx has changed signature for some of the class constructors and methods, that's why the unit tests are failing. For example \GraphQL\Error\Error constructor now excepts only array as the 4th parameter for $positions, while previously it was possible to pass null value.

I've prepared the update with the latest changes from master, newer version of webonyx/graphql and fixed unit tests. If you allow me I'll push the changes to your branch.

Hey @devmaslov,

sorry for the delay before responding!

You're very welcome in pushing these changes onto this branch :-)

Codecov Report

Merging #327 (9970c28) into master (8f8f6be) will decrease coverage by 1.17%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
- Coverage     98.30%   97.12%   -1.18%     
+ Complexity     1778     1578     -200     
============================================
  Files           147      144       -3     
  Lines          4125     4072      -53     
============================================
- Hits           4055     3955     -100     
- Misses           70      117      +47     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8f6be...9970c28. Read the comment docs.

Thanks @xyng

Alright, tests are passing through and everything seems to work fine 😄
@moufmouf, @oojacoboo, what's our plan? Merge it and push live along side with #269 under version 5.0?

@devmaslov the plan is to release 4.2 with #269, as it doesn't have any breaking changes. Then, target a 5.0 release for this. Could you email me so we can have a thread for getting on the same page with these things among others (email on profile).

@devmaslov the plan is to release 4.2 with #269, as it doesn't have any breaking changes. Then, target a 5.0 release for this. Could you email me so we can have a thread for getting on the same page with these things among others (email on profile).

Is there a plan for merging this, I would be eager to help the migration in any way.
I see that the 4.2 version hasn't been released yet so just wondering if it's delayed because of that

@aszenz @moufmouf has been sort of MIA. He's busy with a new project that's consuming most of his time and really hasn't been able to be attentive here. I don't think there is really much of a migration required for a new release. However, I was waiting on details regarding release requirements. I'm not familiar with how the docs are handled, for instance.

But, as far as a release goes, we should be able to tag a new release on master. I can give all this a go soon if @moufmouf doesn't chime in.

Updated: I meant @moufmouf not @devmaslov

@aszenz @devmaslov has been sort of MIA. He's busy with a new project that's consuming most of his time and really hasn't been able to be attentive here. I don't think there is really much of a migration required for a new release. However, I was waiting on details regarding release requirements. I'm not familiar with how the docs are handled, for instance.

But, as far as a release goes, we should be able to tag a new release on master. I can give all this a go soon if @devmaslov doesn't chime in.

Ok, I would like the release to go ahead.

One more thing, there are lots of people excited about graphql in symfony slack channel, maybe we should setup a channel there to collaborate on this wonderful library

Is there anything I could do to help you getting this merged? :-)

@xyng the CI and checks have been cleaned up now and should be passing. They need to be re-run.

https://stackoverflow.com/questions/52408592/how-to-relaunch-github-check-without-pushing-new-commits/52412240

That should give us a better indication of issues with this PR.

Should be rebased onto master instead

Any updates on when this PR will be merged?

@MartynasKasp we need all the tests passing before this can be merged in. Ping @xyng

I'll check the tests and try to resolve them in a few days.

I misread your comment from 2021-08-18 and thought you only wanted a merge from master. ;-)

So I did some debugging and changes. Tests are passing for me locally.
That being said, I'm unsure if the necessary changes are correct or break stuff.
I'd appreciate some feedback of people with deeper understanding of the code. :-)

The CI for a0df970 probably failed because composer pulled the lowest possible version, where as my local composer install did fetch the latest 14.9.0.
Could you please approve the workflows to run for e276fb3?

I created this merge request to your branch, if it's okay with you, it seems to be working alright, and it feels less like a horrible hack than my previous proposal.

I'm a little confused that tests fail here as they did pass locally.
But you're right - findField seems to not always get types right.

I'm happy with your pull-request however I'd prefer approval for that additional change of a contributor of this project before merging that into this pr and eventually cluttering it.
(I could not find you in the contributors-list so I assume you are just another random person like me :-))

I actually work at TheCodingMachine, but only just took my first dive into graphqlite. @moufmouf, can you take a look at these changes I proposed?

I'm happy with your pull-request however I'd prefer approval for that additional change of a contributor of this project before merging that into this pr and eventually cluttering it.

Hey @xyng! First of all, thanks a lot for this PR, it's great!
I think you can safely merge @dsavina PR into your PR. It looks good to me and it should help tests to pass!

Hey @dsavina I just merged your changes.
Could you (or someone else with permissions) maybe approve the workflow run?

@xyng Done!

Documentation generation failed, however I can see that running this job on pull requests is only recent.

@oojacoboo, did we miss something?

It seems like there was a permission error for doc generation action:

remote: Permission to thecodingmachine/graphqlite.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/thecodingmachine/graphqlite.git/': The requested URL returned error: 403

I don't get why this push was attempted in the first place: this is only a pull request, shouldn't the documentation be deployed only after this is merged?

As discussed with @moufmouf, this PR is ready to merge.

I've created #394 to fix the documentation deployment issue, which can simply be ignored here (at least we know that the build of the documentation succeeded).

Hello everyone. Any news? Any suggestions when the release will be? Thanks for your work!

I noticed that #394 got merged and rebased this pr to the updated master.
Could someone please approve the workflow-run (it won't run automatically as I am a first-time contributor), so we can see if they pass now? :-)

@xyng Done!

Excellent! Before we merge this, shouldn't we consider upgrading the version alias in Composer?

https://github.com/thecodingmachine/graphqlite/blob/master/composer.json#L66-L70

A lot of projects must be depending on webonyx to be in 0.13 without properly stating this dependency in their composer.json (because it is a transititive dependency via GraphQLite). Should we upgrade the version number to 5.x ?

@moufmouf I set the version to 5.0.0 - if you decide against setting this in this pr I can remove the commit.

Edit: Sorry I got the file wrong :-) I've changed the commit so it updates the branch-alias.

Looks good to me!
Let's merge this 👍