-
-
Notifications
You must be signed in to change notification settings - Fork 771
OpenTitan: Run tests #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
OpenTitan: Run tests #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
413801d
to
7ef08fc
Compare
2 tasks
ppannuto
previously approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the platform selection logic is probably a bit awkward (depending on the magic-ish environment variable), but this is nicely contained to /boards
, and I think we're comfortably in the try-out-a-few-approaches phase.
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
7ef08fc
to
e6fd89b
Compare
Rebased and good to go |
hudson-ayers
approved these changes
Jul 1, 2021
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 29, 2021
2644: OpenTitan: Bump the FPGA bitstream r=phil-levis a=alistair23 ### Pull Request Overview This PR builds on top of #2634 This PR bumps the OpenTitan bitstream SHA. This means three things 1. Some small changes to handle the new design 2. The OTBN tests no longer work as OTBN has been removed from the FPGA build. This isn't ideal, but we can't hold the work back on this 3. We can enable the flash tests as lowRISC/opentitan#4730 is now fixed ### Testing Strategy The built in OpenTitan tests ### TODO or Help Wanted `@jrvanwhy` or `@silvestrst` can someone please upload a new release to https://storage.googleapis.com/artifacts.opentitan.org/ ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
last-call
Final review period for a pull request.
WG-OpenTitan
In the purview of the OpenTitan working group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR builds on #2629 and adds tests for the OpenTitan board.
Testing Strategy
This PR!
TODO or Help Wanted
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.