Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

This PR builds on #2629 and adds tests for the OpenTitan board.

Testing Strategy

This PR!

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Jun 28, 2021
@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Jun 29, 2021
@alistair23 alistair23 force-pushed the alistair/ot-testing branch from 413801d to 7ef08fc Compare July 1, 2021 05:30
@ppannuto ppannuto removed the blocked Waiting on something, like a different PR or a dependency. label Jul 1, 2021
ppannuto
ppannuto previously approved these changes Jul 1, 2021
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the platform selection logic is probably a bit awkward (depending on the magic-ish environment variable), but this is nicely contained to /boards, and I think we're comfortably in the try-out-a-few-approaches phase.

@alistair23
Copy link
Contributor Author

Rebased and good to go

@ppannuto ppannuto added last-call Final review period for a pull request. and removed needs-rebase labels Jul 2, 2021
@bradjc
Copy link
Contributor

bradjc commented Jul 6, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 6, 2021

@bors bors bot merged commit 76518b5 into tock:master Jul 6, 2021
@alistair23 alistair23 deleted the alistair/ot-testing branch July 6, 2021 23:28
bors bot added a commit that referenced this pull request Jul 29, 2021
2644: OpenTitan: Bump the FPGA bitstream r=phil-levis a=alistair23

### Pull Request Overview

This PR builds on top of #2634

This PR bumps the OpenTitan bitstream SHA. This means three things
 1. Some small changes to handle the new design
 2. The OTBN tests no longer work as OTBN has been removed from the FPGA build. This isn't ideal, but we can't hold the work back on this
 3. We can enable the flash tests as lowRISC/opentitan#4730 is now fixed

### Testing Strategy

The built in OpenTitan tests

### TODO or Help Wanted

`@jrvanwhy`  or `@silvestrst` can someone please upload a new release to https://storage.googleapis.com/artifacts.opentitan.org/

### Documentation Updated

- [X] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [X] Ran `make prepush`.


Co-authored-by: Alistair Francis <[email protected]>
@hudson-ayers hudson-ayers mentioned this pull request Aug 9, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request. WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants