-
-
Notifications
You must be signed in to change notification settings - Fork 771
[spi] Update virtual_spi to report errors #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
reviewed
Aug 17, 2021
hudson-ayers
approved these changes
Aug 19, 2021
bradjc
approved these changes
Aug 19, 2021
lschuermann
approved these changes
Aug 19, 2021
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the virtual spi driver to report back errors. In case of errors, the virtual spi driver was setting the
op
variable toReadWriteDone
and was callingdo_next_op_async
. The next timedo_next_op
was run, it was not doing anything as it thought the mix was in flight.It also:
Testing Strategy
This pull request was tested using a Pico Explorer Base
TODO or Help Wanted
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.