Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

alexandruradovici
Copy link
Contributor

@alexandruradovici alexandruradovici commented Aug 17, 2021

Pull Request Overview

This pull request updates the virtual spi driver to report back errors. In case of errors, the virtual spi driver was setting the op variable to ReadWriteDone and was calling do_next_op_async. The next time do_next_op was run, it was not doing anything as it thought the mix was in flight.

It also:

  • adds error reporting to the bus library
  • fixes the screen driver to report errors
  • updates the bus component to take the spi to accept the spi configuration as arguments

Testing Strategy

This pull request was tested using a Pico Explorer Base

TODO or Help Wanted

  • test using the Adafruit Clue nRF52840

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@alexandruradovici alexandruradovici changed the title [spi] Udpate virtual_spi [spi] Update virtual_spi to report errors Aug 17, 2021
@irina-b-dev irina-b-dev mentioned this pull request Aug 17, 2021
23 tasks
@bradjc
Copy link
Contributor

bradjc commented Aug 19, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 19, 2021

@bors bors bot merged commit bb6fe64 into tock:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants