tools: clippy: list all complexity and style lints #3607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to see which ones we can fix.
brghena
previously approved these changes
Aug 11, 2023
hudson-ayers
previously approved these changes
Aug 11, 2023
We pass none of these. That is how I found them. |
ppannuto
approved these changes
Aug 11, 2023
|
Do we want to move forward with this? This is a step towards using clippy more generally. I have a few branches with fixes/changes to meet various clippy lints. Luckily |
lschuermann
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This lists out which complexity and styles lints we currently need to allow. I grouped them based on lints that seem like reasonable issues we should fix, lints we may want to fix depending on the diff, and lints we most likely will not use.
Part of #3572.
This is potentially an important change because we are adding many clippy lints that we weren't previously.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.