Clippy: Enable many style lints #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
reviewed
Aug 23, 2023
| Self { | ||
| 0: [0; SECTOR_SIZE as usize], | ||
| } | ||
| Self([0; SECTOR_SIZE as usize]) |
There was a problem hiding this comment.
Wow, this old syntax is positively terrifying. Who knew that you could do that!
lschuermann
previously approved these changes
Aug 23, 2023
ppannuto
requested changes
Aug 23, 2023
| @@ -49,7 +49,7 @@ impl AddrRange { | |||
| let full_bytes: usize = prefix_len / 8; | |||
| let remainder_bits: usize = prefix_len % 8; | |||
| // initial bytes -- TODO: edge case | |||
| if &allowed_addr.0[0..full_bytes] != &addr.0[0..full_bytes] { | |||
| if allowed_addr.0[0..full_bytes] != addr.0[0..full_bytes] { | |||
There was a problem hiding this comment.
The fact that these two expressions are equivalent... this is why borrows are so hard to teach :/
6c36b07 to
eb5d24c
Compare
ppannuto
previously approved these changes
Aug 29, 2023
lschuermann
previously approved these changes
Aug 29, 2023
eb5d24c to
9469f30
Compare
hudson-ayers
previously approved these changes
Sep 5, 2023
alevy
previously approved these changes
Sep 7, 2023
9469f30 to
53983b5
Compare
ppannuto
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request enables many of the clippy style lints that to me seem noncontroversial.
You can see the change made by each one in each commit. If one seems like it needs more discussion I'm happy to move it to a new PR.
I also fixed a mistake from an earlier clippy PR where we both denied and allowed a flag (before I decided to enumerate all allows).
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.