Fix backup behat #773786 #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great - many thanks danghieu. I'm pleased you found a nice easy fix (turning off async backup). When I first saw the problem I thought it was going to be difficult to fix. |
trampgeek
pushed a commit
that referenced
this pull request
Apr 14, 2024
Co-authored-by: DangHieu1407 <[email protected]>
|
You've probably already seen the pull request #214 and the subsequent discussion, but I thought I'd draw your attention to it just in case you hadn't. Many thanks Richard |
|
Hi @trampgeek, I've seen that pull request. The owner of that pull request is my colleague. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @trampgeek ,
I have found the root cause of the CI failure. There is a new change in Moodle master. I saw that another person fix the issue back up in this link.
I have updated the behat. Could you please have a look at this change?
Many thanks.