Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CodeRunner Question: Full screen icon present on editor is not workin… #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BruceGoodGuy
Copy link

Hi @trampgeek ,

Recently, we received feedback that the feature fullscreen button (relative to the pull request: #187) does not work correctly on Safari browsers on iPhone devices. It happens because requestFullscreen() method does not support Safari browsers on iPhones as well. Here are the documents: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen. Due to the limitations of the technical, I suggest hiding the fullscreen button on all mobile devices to make it less confusing to the user.
I believe this feature is not necessary for mobile devices, and to make it consistent between iOS and Android devices, hiding the FullScreen button for all mobile devices is necessary.

And here is the pull request to make it work.
What do you think?
Please give me any feedback if it doesn't satisfy you.

@trampgeek
Copy link
Owner

Hi @BruceGoodGuy

Thanks for reporting. However, I'd be reluctant to disable the full screen functionality on all mobile devices just because Safari on iOS doesn't support it. Although I don't use the functionality myself, I know some of our students do use it and I have been amazed by what they will attempt on a cell phone. If anyone is trying to write simple programs on their cell phone, full-screen capability would be just what they'd want? Also, your proposed change would disable the functionality on any Android device, which might include quite large tablets that might have attached keyboards and even screens. Even disabling the functionality on iPhones is questionable, as iPhones have up to a 6.7" display, can have a Bluetooth keyboard and might be running Chrome rather than Safari.

I don't have an iPhone to experiment with, but what happens on an iPhone running Safari if the user touches the full screen icon? If nothing actually happens then I'm inclined to do nothing. Disabling the functionality in that specific situation then creates a maintenance problem down the line if Safari is updated to allow full screening - how would we know? And then we'd have to reenable it again, with checks on the actual version number of Safari.

So, I'm sorry, but this isn't looking like a winner unless there is actually a significant problem arising from iPhone users touching the icon.

@BruceGoodGuy
Copy link
Author

Hi @trampgeek,

Thanks for getting back to me so quickly!

I'm confirming what we discussed earlier. On iPhones using Safari, the editor doesn't currently support fullscreen mode. While users can try to activate fullscreen, nothing happens. In some cases, the fullscreen icon might even disappear after tapping it.

However, as you can see in the attached video I recorded on my iPhone using Safari, this behavior doesn't seem to significantly affect how users interact with the editor (it doesn't impact the user experience). So, based on your analysis in your previous comment, it seems like fixing this issue might not be a high priority.
[

youcanseeit.mp4

](url)
Is that what you meant? Please let me know if my understanding is incorrect.

Thanks,

@trampgeek
Copy link
Owner

Many thanks for the demo video, @BruceGoodGuy. It does seem like the non-working fullscreen functionality is just a very slight annoyance - you'd try the icon maybe a couple of times, see it does nothing, and then forget about it. So while it would be nice to be able to hide it in the current versions of Safari on an iPhone, I don't think fixing it is a priority.

The full-screening was provided by the Open University team, so I'll draw their attention to this issue and they can decide if they wish to do anything about it. In the meantime though I'll close the issue. But thanks again for reporting.

@trampgeek trampgeek closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants