CodeRunner Question: Full screen icon present on editor is not workin… #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @trampgeek ,
Recently, we received feedback that the feature fullscreen button (relative to the pull request: #187) does not work correctly on Safari browsers on iPhone devices. It happens because
requestFullscreen()
method does not support Safari browsers on iPhones as well. Here are the documents: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen. Due to the limitations of the technical, I suggest hiding the fullscreen button on all mobile devices to make it less confusing to the user.I believe this feature is not necessary for mobile devices, and to make it consistent between iOS and Android devices, hiding the FullScreen button for all mobile devices is necessary.
And here is the pull request to make it work.
What do you think?
Please give me any feedback if it doesn't satisfy you.