Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(rule-tester): rethrow exceptions in RuleTester to avoid circular JSON issue #10134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024
Merged

chore(rule-tester): rethrow exceptions in RuleTester to avoid circular JSON issue #10134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d972eb
rethrow exceptions in RuleTester to avoid circular JSON issue
kirkwaiblinger Oct 11, 2024
c799e69
didn't mean to move stuff
kirkwaiblinger Oct 11, 2024
416d69b
switch to simpler approach
kirkwaiblinger Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions packages/rule-tester/src/RuleTester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,31 @@
rules: { [`${RULE_TESTER_PLUGIN_PREFIX}validate-ast`]: 'error' },
});

this.#linter = new Linter({
configType: 'flat',
cwd: this.#testerConfig.languageOptions.parserOptions?.tsconfigRootDir,
});
this.#linter = (() => {
const linter = new Linter({
configType: 'flat',
cwd: this.#testerConfig.languageOptions.parserOptions?.tsconfigRootDir,
});

// This nonsense is a workaround for https://github.com/jestjs/jest/issues/14840
// see also https://github.com/typescript-eslint/typescript-eslint/issues/8942
//
// For some reason rethrowing exceptions skirts around the circular JSON error.
const oldVerify = linter.verify.bind(linter);
linter.verify = (
...args: Parameters<Linter['verify']>
): ReturnType<Linter['verify']> => {
try {
return oldVerify(...args);
} catch (error) {
throw new Error('Caught an error while linting', {

Check warning on line 204 in packages/rule-tester/src/RuleTester.ts

View check run for this annotation

Codecov / codecov/patch

packages/rule-tester/src/RuleTester.ts#L204 

Added line #L204 was not covered by tests
cause: error,
});
}
};

return linter;
})();

// make sure that the parser doesn't hold onto file handles between tests
// on linux (i.e. our CI env), there can be very a limited number of watch handles available
Expand Down
Loading