fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

mdm317 · 2025-09-12T10:54:31Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-base-to-string] ignoredTypeNames should match on the type name without generics #11521
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Make ignoredTypeNames match type names without generics

typescript-eslint · 2025-09-12T10:54:34Z

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-09-12T10:55:04Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`8c9043a`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68c3fbe9232fba00084e6418
😎 Deploy Preview	https://deploy-preview-11597--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 10 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-09-12T10:56:11Z

View your CI Pipeline Execution ↗ for commit 8c9043a

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4m 59s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 14s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 5s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-12 11:07:28 UTC

codecov · 2025-09-12T11:07:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (95c7287) to head (8c9043a).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11597   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         505      505           
  Lines       51208    51224   +16     
  Branches     8441     8450    +9     
=======================================
+ Hits        46551    46567   +16     
  Misses       4644     4644           
  Partials       13       13

Flag	Coverage Δ
unittest	`90.90% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`98.99% <100.00%> (+0.05%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

Thanks! ✨

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fix: support generic in ignoreType

8c9043a

mdm317 marked this pull request as ready for review September 12, 2025 11:07

JoshuaKGoldberg approved these changes Sep 15, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 15, 2025

JoshuaKGoldberg merged commit 4fde781 into typescript-eslint:main Sep 22, 2025
64 checks passed

chrisbbreuer mentioned this pull request Sep 22, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#64

Closed

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request Sep 22, 2025

Port typescript-eslint/typescript-eslint#11597

d045841

fossabot bot mentioned this pull request Sep 29, 2025

Bump @typescript-eslint/eslint-plugin from 8.42.0 to 8.44.1 fossas/fossa-action#210

Merged

chrisbbreuer mentioned this pull request Oct 4, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

This was referenced Oct 6, 2025

chore(deps-dev): bump the dependencies group with 4 updates openfga/js-sdk#263

Merged

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0 fossas/fossa-action#220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

mdm317 commented Sep 12, 2025

Uh oh!

typescript-eslint bot commented Sep 12, 2025

Uh oh!

netlify bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

Conversation

mdm317 commented Sep 12, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Sep 12, 2025

Uh oh!

netlify bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Sep 12, 2025 •

edited

Loading

nx-cloud bot commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading