Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 29, 2025

Reverts #11616

I'd like to get the change back in, but it's non-trivial to work around #11662.

Fixes #11662.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c80d100
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68dacf387a00670008e5b024
😎 Deploy Preview https://deploy-preview-11663--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 14 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 29, 2025

View your CI Pipeline Execution ↗ for commit c80d100

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 16s View ↗
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-29 18:42:18 UTC

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the details, but I remember previously nx was super picky about the PR title for a revert PR, so might be worth double checking that before merging

@JoshuaKGoldberg JoshuaKGoldberg merged commit db09a7d into main Sep 29, 2025
66 of 69 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-11616-feat/add-name-to-rulemodule branch September 29, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: (regression) name should be optional in RuleCreator.withoutDocs

3 participants