Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "feat(eslint-plugin): expose rule name via RuleModule interface" #11663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Revert "feat(eslint-plugin): expose rule name via RuleModule interface" #11663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ ruleTester.defineRule('use-every-a', {
schema: [],
type: 'problem',
},
name: 'use-every-a',
});

/**
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ ruleTester.defineRule('collect-unused-vars', {
schema: [],
type: 'problem',
},
name: 'collect-unused-vars',
});

ruleTester.run('no-unused-vars', rule, {
Expand Down
6 changes: 0 additions & 6 deletions packages/rule-tester/tests/RuleTester.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ const NOOP_RULE: RuleModule<'error'> = {
schema: [],
type: 'problem',
},
name: 'rule',
};

function windowsToPosixPath(p: string): string {
Expand Down Expand Up @@ -1109,7 +1108,6 @@ describe('RuleTester - hooks', () => {
schema: [],
type: 'problem',
},
name: 'rule',
};

const ruleTester = new RuleTester();
Expand Down Expand Up @@ -1333,7 +1331,6 @@ describe('RuleTester - multipass fixer', () => {
schema: [],
type: 'problem',
},
name: 'rule',
};

it('passes with no output', () => {
Expand Down Expand Up @@ -1419,7 +1416,6 @@ describe('RuleTester - multipass fixer', () => {
schema: [],
type: 'problem',
},
name: 'rule',
};

it('passes with correct string output', () => {
Expand Down Expand Up @@ -1542,7 +1538,6 @@ describe('RuleTester - multipass fixer', () => {
schema: [],
type: 'problem',
},
name: 'rule',
};

it('passes with correct array output', () => {
Expand Down Expand Up @@ -1649,7 +1644,6 @@ describe('RuleTester - run types', () => {
],
type: 'suggestion',
},
name: 'rule',
};

describe('infer from `rule` parameter', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/rule-tester/tests/filename.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({
type: 'problem',
hasSuggestions: true,
},
name: 'rule',
defaultOptions: [],
create: context => ({
Program(node): void {
Expand Down
4 changes: 0 additions & 4 deletions packages/utils/src/eslint-utils/RuleCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export interface RuleWithMeta<
Docs = unknown,
> extends RuleCreateAndOptions<Options, MessageIds> {
meta: RuleMetaData<MessageIds, Docs, Options>;
name: string;
}

export interface RuleWithMetaAndName<
Expand Down Expand Up @@ -77,7 +76,6 @@ export function RuleCreator<PluginDocs = unknown>(
url: urlCreator(name),
},
},
name,
...rule,
});
};
Expand All @@ -91,7 +89,6 @@ function createRule<
create,
defaultOptions,
meta,
name,
}: Readonly<RuleWithMeta<Options, MessageIds, PluginDocs>>): RuleModule<
MessageIds,
Options,
Expand All @@ -104,7 +101,6 @@ function createRule<
},
defaultOptions,
meta,
name,
};
}

Expand Down
5 changes: 0 additions & 5 deletions packages/utils/src/ts-eslint/Rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,11 +735,6 @@ export interface RuleModule<
* Metadata about the rule
*/
meta: RuleMetaData<MessageIds, Docs, Options>;

/**
* Rule name
*/
name: string;
}

export type AnyRuleModule = RuleModule<string, readonly unknown[]>;
Expand Down
Loading