Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): handle override modifier in promise-function-async fixer #11730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+82 −3
Merged

fix(eslint-plugin): handle override modifier in promise-function-async fixer #11730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e761dcf
fix(eslint-plugin): handle override modifier in promise-function-asyn…
sushichan044 Oct 31, 2025
e3d0dbb
fill issue number
sushichan044 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/eslint-plugin/src/rules/promise-function-async.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,16 @@ export default createRule<Options, MessageIds>({
);
}

// if current token is a keyword like `static` or `public` then skip it
// if current token is a keyword like `static` or `public`, or the `override` modifier, then skip it
while (
keyToken.type === AST_TOKEN_TYPES.Keyword &&
(keyToken.type === AST_TOKEN_TYPES.Keyword ||
(keyToken.type === AST_TOKEN_TYPES.Identifier &&
keyToken.value === 'override')) &&
keyToken.range[0] < method.key.range[0]
) {
keyToken = nullThrows(
context.sourceCode.getTokenAfter(keyToken),
NullThrowsReasons.MissingToken('token', 'keyword'),
NullThrowsReasons.MissingToken('token', 'modifier keyword'),
);
}

Expand Down
77 changes: 77 additions & 0 deletions packages/eslint-plugin/tests/rules/promise-function-async.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,26 @@ function overloadingThatIncludeAny(a?: boolean): any | number {
`,
options: [{ allowAny: true }],
},
`
class Base {
async foo() {
return Promise.resolve(42);
}
}

class Derived extends Base {
override async foo() {
return Promise.resolve(2000);
}
}
`,
`
class Test {
public override async method() {
return Promise.resolve(1);
}
}
`,
],
invalid: [
{
Expand Down Expand Up @@ -942,5 +962,62 @@ function overloadingThatIncludeUnknown(a?: boolean): unknown | number {
],
options: [{ allowAny: false }],
},
// https://github.com/typescript-eslint/typescript-eslint/issues/11729
{
code: `
class Base {
async foo() {
return Promise.resolve(42);
}
}

class Derived extends Base {
override foo() {
return Promise.resolve(2000);
}
}
`,
errors: [
{
line: 9,
messageId: 'missingAsync',
},
],
output: `
class Base {
async foo() {
return Promise.resolve(42);
}
}

class Derived extends Base {
override async foo() {
return Promise.resolve(2000);
}
}
`,
},
{
code: `
class Test {
public override method() {
return Promise.resolve(1);
}
}
`,
errors: [
{
line: 3,
messageId: 'missingAsync',
},
],
output: `
class Test {
public override async method() {
return Promise.resolve(1);
}
}
`,
},
],
});
Loading