Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2022
Merged

fix: revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now #4740

merged 2 commits into from
Mar 26, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

Reverts #4710. 😢

@bradzacher I was so hopeful about it too..

@nx-cloud
Copy link

nx-cloud bot commented Mar 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ed5506e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 41 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 26, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ed5506e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/623f9d698ce0410009590abb
😎 Deploy Preview https://deploy-preview-4740--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bradzacher
bradzacher previously approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's some things we need to update manually first?

@JoshuaKGoldberg JoshuaKGoldberg changed the title Revert "chore: Bump cypress from 8.3.0 to 9.5.2" Revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now Mar 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title Revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now fix: revert "chore: Bump cypress from 8.3.0 to 9.5.2", and ignore cypress for now Mar 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) March 26, 2022 23:10
@JoshuaKGoldberg
Copy link
Member Author

Yeah, once the outstanding Cypress issues about flake in CI are resolved I think we can try this again.

@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #4740 (ed5506e) into main (9707daa) will increase coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
+ Coverage   92.06%   92.63%   +0.57%     
==========================================
  Files         355      317      -38     
  Lines       12097    11698     -399     
  Branches     3455     3415      -40     
==========================================
- Hits        11137    10837     -300     
+ Misses        630      561      -69     
+ Partials      330      300      -30
Flag Coverage Δ
unittest 92.63% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/ast-utils/helpers.ts
packages/utils/src/ts-eslint/ESLint.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
packages/utils/src/eslint-utils/deepMerge.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/visitor-keys/src/get-keys.ts
packages/utils/src/ts-eslint/Scope.ts
packages/utils/src/eslint-utils/applyDefault.ts
.../utils/src/ast-utils/eslint-utils/scopeAnalysis.ts
packages/utils/src/ast-utils/eslint-utils/index.ts
... and 28 more

@JoshuaKGoldberg JoshuaKGoldberg merged commit cf5f5c4 into main Mar 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-4710-dependabot/npm_and_yarn/cypress-9.5.2 branch March 26, 2022 23:25
This was referenced Mar 27, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher