Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: update babel alignment tests to latest version #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2022
Merged

test: update babel alignment tests to latest version #4774

merged 1 commit into from
Apr 5, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Apr 2, 2022 •
edited
Loading

PR Checklist

Overview

this change is required for merge of #4692

@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37f2b03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 2, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 37f2b03
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62481253673e5200096ed0b6
😎 Deploy Preview https://deploy-preview-4774--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 added the tests anything to do with testing label Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022 •
edited
Loading

Codecov Report

Merging #4774 (37f2b03) into main (c59d9d7) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4774      +/-   ##
==========================================
- Coverage   94.28%   93.97%   -0.32%     
==========================================
  Files         151      172      +21     
  Lines        8208     9806    +1598     
  Branches     2670     3103     +433     
==========================================
+ Hits         7739     9215    +1476     
- Misses        261      352      +91     
- Partials      208      239      +31
Flag Coverage Δ
unittest 93.97% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 78.06% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 91.30% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <0.00%> (ø)
...estree/src/create-program/createIsolatedProgram.ts 75.00% <0.00%> (ø)
packages/typescript-estree/src/convert.ts 98.39% <0.00%> (ø)
packages/typescript-estree/src/node-utils.ts 98.29% <0.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts 77.27% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 89.79% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 84.32% <0.00%> (ø)
packages/typescript-estree/src/convert-comments.ts 100.00% <0.00%> (ø)
... and 11 more

@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Apr 2, 2022
JoshuaKGoldberg
JoshuaKGoldberg reviewed Apr 3, 2022
View reviewed changes
packages/shared-fixtures/fixtures/typescript/basics/never-type-param.src.ts
@@ -1,2 +1,2 @@
const x: X<never>;
var x: X<never>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my learning: why the change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel reports now errors for unidealized const variables, witch is tested in

    /**
     * [BABEL ERRORED, BUT TS-ESTREE DID NOT]
     * SyntaxError: Missing initializer in const declaration.
     */
    'var-with-definite-assignment',

JamesHenry
JamesHenry approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see some of these ancient discrepancies have been resolved on the babel side 🎉

@bradzacher bradzacher merged commit de68e5e into main Apr 5, 2022
@armano2 armano2 deleted the test/update-babel-tests branch April 6, 2022 00:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armano2 @JamesHenry @JoshuaKGoldberg @bradzacher