fix(eslint-plugin): refactor lint script to run all projects without running eslint-plugin separately #8779
Conversation
…slint-plugin separately
|
Thanks for the PR, @abarghoud! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@abarghoud Have you looked at @JamesHenry's PR #8539 where linting #8373 as well |
@abrahamguo Thank you for bringing up PR #8539 and issue #8373. I've reviewed both and understand the context behind breaking out linting for eslint-plugin. It appears that the flakiness issues observed in those PRs were specific to the CI environment. My PR has passed all CI checks, including linting, which assures that it's aligned with project standards and hasn't introduced regressions. According to what @JoshuaKGoldberg said in #8373 description
Is there any way I can reproduce the flakiness that was happening? |
PR Checklist
yarn lint-fixin this repository doesn't work on theeslint-pluginpackage #8733Overview
The current lint script sequence includes a direct linting command followed by additional linting tasks executed through NX CLI. However, this approach has led to unintended consequences due to how Yarn forwards arguments at the end of the called script, particularly when attempting to pass options such as --fix.
By removing the direct linting command and focusing solely on executing linting tasks through NX CLI, we can avoid the issue altogether. This simplification streamlines the script and eliminates potential conflicts arising from Yarn's argument forwarding behavior.