Make expErrors use an array (and only an array) #1076

mihnita · 2025-06-02T15:02:14Z

Fixes issue #993

aphillips · 2025-06-02T15:26:42Z

test/tests/functions/datetime.json

@@ -5,7 +5,7 @@
  "defaultTestProperties": {
    "bidiIsolation": "none",
    "locale": "en-US",
-    "expErrors": false
+    "expErrors": []


In fallback.md you left out expErrors. Here you supply an empty array. I think we should probably omit this one?

@aphillips It's required in this file otherwise some tests would be left without an expectation (e.g. lines 44-55). This would also be the case in time.json.

As Eemeli mentioned in his review comment, I think we need to keep the expErrors in fallback.md.

I think we are talking about fallback.json, not fallback.md?

I updated fallback.json and added errors for each individual case, instead of doing it in defaultTestProperties

For date.json, datetime.json and time.json I added "expErrors": [] to defaultTestProperties because the schema says that entries are required to have one of exp, expParts or expErrors

In these 3 files we had tests with src only.
So I had to add a expErrors (not enough info for exp, expParts, exact date/time formatting not part of the spec)

aphillips · 2025-06-02T15:26:50Z

test/tests/functions/time.json

@@ -5,7 +5,7 @@
  "defaultTestProperties": {
    "bidiIsolation": "none",
    "locale": "en-US",
-    "expErrors": false
+    "expErrors": []


eemeli · 2025-06-02T15:34:46Z

test/tests/fallback.json

@@ -4,8 +4,7 @@
  "description": "Test cases for fallback behaviour.",
  "defaultTestProperties": {
    "bidiIsolation": "none",
-    "locale": "en-US",
-    "expErrors": true


Was dropping this intentional? All of the messages in this file are expected to experience fallback and emit at least one error.

I added what I though to be the most appropriate errors for each case.

For :test:function fails=format the test/README.md is not specific enough, it only says "will emit a Message Function Error".

So from all the message function errors I chose the one that I though might be the best fit, Bad Operand, and I also updated the README.md file with it.

I did that for both fails=format and fails=select.

eemeli

Some fixes, may need a second pass later to make sure I caught everything.

eemeli · 2025-06-08T08:20:19Z

test/README.md

@@ -155,7 +155,7 @@ the behaviour of calling it as the `rv` value of MatchSelectorKeys(`rv`, `keys`)
 depends on its `Input`, `DecimalPlaces` and `FailsSelect` values.

 - If `FailsSelect` is `true`,
-  calling the method will emit a _Message Function Error_
+  calling the method will emit a _Message Function Error_ of type _Bad Operand_


Suggested change

calling the method will emit a _Message Function Error_ of type _Bad Operand_

calling the method will emit a _Bad Operand_ error

eemeli · 2025-06-08T08:20:35Z

test/README.md

@@ -185,7 +185,7 @@ rather than being concatenated into a single string.

 If `FailsFormat` is `true`,
 attempting to format the _placeholder_ to any formatting target will
-emit a _Message Function Error_.
+emit a _Message Function Error_ of type _Bad Operand_.


Suggested change

emit a _Message Function Error_ of type _Bad Operand_.

emit a _Bad Operand_ error.

eemeli · 2025-06-08T08:21:34Z

test/tests/fallback.json

    },
    {
      "description": "unannotated implicit input variable",
      "src": "{$var}",
-      "exp": "{$var}"
+      "exp": "{$var}",
+      "expErrors": [{ "type": "bad-operand" }]


Suggested change

"expErrors": [{ "type": "bad-operand" }]

"expErrors": [{ "type": "unresolved-variable" }]

eemeli · 2025-06-08T08:22:39Z

test/tests/fallback.json

    },
    {
      "description": "annotated implicit input variable",
      "src": "{$var :number}",
      "exp": "{$var}",
-      "expParts": [{ "type": "fallback", "source": "$var" }]
+      "expParts": [{ "type": "fallback", "source": "$var" }],
+      "expErrors": [{ "type": "bad-operand" }]


Suggested change

"expErrors": [{ "type": "bad-operand" }]

"expErrors": [{ "type": "unresolved-variable" }, { "type": "bad-operand" }]

eemeli · 2025-06-08T08:25:41Z

test/tests/fallback.json

    },
    {
      "description": "function with local variable operand with unknown function in declaration",
      "src": ".local $var = {|val| :test:undefined} {{{$var :test:function}}}",
-      "exp": "{$var}"
+      "exp": "{$var}",
+      "expErrors": [{ "type": "unknown-function" }]


Suggested change

"expErrors": [{ "type": "unknown-function" }]

"expErrors": [{ "type": "unknown-function" }, { "type": "bad-operand" }]

eemeli · 2025-06-08T08:26:16Z

test/tests/fallback.json

    },
    {
      "description": "function with no operand",
      "src": "{:test:undefined}",
      "exp": "{:test:undefined}",
-      "expParts": [{ "type": "fallback", "source": ":test:undefined" }]
+      "expParts": [{ "type": "fallback", "source": ":test:undefined" }],
+      "expErrors": [{ "type": "bad-operand" }]


Suggested change

"expErrors": [{ "type": "bad-operand" }]

"expErrors": [{ "type": "unknown-function" }]

mihnita force-pushed the mihai_issue_933 branch from e0def62 to b0e39a0 Compare June 2, 2025 15:03

Issue 993: make expErrors only

3f11bcb

mihnita force-pushed the mihai_issue_933 branch from b0e39a0 to 3f11bcb Compare June 2, 2025 15:20

mihnita requested review from eemeli, mradbourne and aphillips and removed request for eemeli June 2, 2025 15:22

aphillips reviewed Jun 2, 2025

View reviewed changes

aphillips added the test-suite Issue pertains to tests label Jun 2, 2025

aphillips changed the title ~~Issue 993: make expErrors only~~ Make expErrors use an array (and only an array) Jun 2, 2025

eemeli reviewed Jun 2, 2025

View reviewed changes

Adding expErrors values for fallback.json

51a2a4b

eemeli requested changes Jun 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Make expErrors use an array (and only an array) #1076

Make expErrors use an array (and only an array) #1076

mihnita commented Jun 2, 2025 •

edited

Loading

Uh oh!

aphillips Jun 2, 2025

Uh oh!

mradbourne Jun 5, 2025

Uh oh!

mihnita Jun 8, 2025

Uh oh!

mihnita Jun 8, 2025

Uh oh!

aphillips Jun 2, 2025

Uh oh!

mihnita Jun 8, 2025

Uh oh!

eemeli Jun 2, 2025

Uh oh!

mihnita Jun 8, 2025

Uh oh!

eemeli left a comment

Uh oh!

eemeli Jun 8, 2025

Uh oh!

eemeli Jun 8, 2025

Uh oh!

eemeli Jun 8, 2025

Uh oh!

eemeli Jun 8, 2025

Uh oh!

eemeli Jun 8, 2025

Uh oh!

eemeli Jun 8, 2025

Uh oh!

Uh oh!

	calling the method will emit a _Message Function Error_ of type _Bad Operand_
	calling the method will emit a _Bad Operand_ error

	emit a _Message Function Error_ of type _Bad Operand_.
	emit a _Bad Operand_ error.

	"expErrors": [{ "type": "bad-operand" }]
	"expErrors": [{ "type": "unresolved-variable" }]

	"expErrors": [{ "type": "unknown-function" }]
	"expErrors": [{ "type": "unknown-function" }, { "type": "bad-operand" }]

Uh oh!

Make expErrors use an array (and only an array) #1076

Are you sure you want to change the base?

Make expErrors use an array (and only an array) #1076

Conversation

mihnita commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eemeli left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mihnita commented Jun 2, 2025 •

edited

Loading