Unicode 15.1 version numbers #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
050c108 to
6ccba6c
Compare
6ccba6c to
a7d88a8
Compare
nedley
reviewed
Oct 4, 2022
| @@ -43,16 +43,16 @@ jobs: | |||
| run: > | |||
| mkdir -pv $(pwd)/output/Generated/ && | |||
| mvn -s .github/workflows/mvn-settings.xml -B exec:java | |||
| -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version 15.0.0 build MakeUnicodeFiles" | |||
| -Dexec.mainClass="org.unicode.text.UCD.Main" -Dexec.args="version 15.1.0 build MakeUnicodeFiles" | |||
There was a problem hiding this comment.
Is there any way to expand this from the CURRENT_UVERSION token in cli-build-instructions.yml?
There was a problem hiding this comment.
I suspect not, since it's in a different workflow file. But I am no expert in GitHub Actions.
There was a problem hiding this comment.
I am entirely unsure myself, but even if we needed to create a new file containing just the constant such that it could be used by the others I think it would be worth doing.
|
I ran the UCD file generator and added a second commit with minor version number changes in generated segmentation .html files. |
Manishearth
approved these changes
Oct 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating version numbers, with latestVersion=15.1.0.
I also modified GenerateEnums.java to write
@Overrideannotations that Eclipse adds automatically, so that when one touches UcdPropertyValues.java in Eclipse, the CI check does not complain about unexpected diffs.The second commit makes minor version number changes in generated segmentation .html files.