Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unicode 15.1→16.0 #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2023
Merged

Unicode 15.1→16.0 #539

merged 4 commits into from
Sep 19, 2023

Conversation

markusicu
Copy link
Member

@markusicu markusicu commented Sep 19, 2023 •
edited
Loading

Best to review one commit at a time:

  • copy the data "dev" folders to "15.1(.0)"
  • add version 16.0, adjust latest & last version numbers
  • generated files
  • fix tests

Compare with moving to 15.1 last year:

@srl295
Copy link
Member

srl295 commented Sep 19, 2023

Reviewed all but the "copy" commit, looks good so far

srl295
srl295 previously approved these changes Sep 19, 2023
View reviewed changes
Ken-Whistler
Ken-Whistler previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Ken-Whistler Ken-Whistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presuming this is just the rollover for the 16.0 base, using the 15.1 data. No comments on the tooling changes per se.

@markusicu markusicu dismissed stale reviews from Ken-Whistler and srl295 via 05d18a1 September 19, 2023 21:49
@markusicu
Copy link
Member Author

@nedley: I amended the second commit to include tools/emoji/Emoji.java, and I made that a little less manual.

@markusicu
Copy link
Member Author

I fixed the test failure. CheckProperties has another parser of numeric values. I don't know why it fails only with the previous version having multiple kPrimaryNumericValues but works if the current version has them. Now it only looks at the first value.

@markusicu markusicu merged commit 4da6718 into unicode-org:main Sep 19, 2023
@markusicu markusicu deleted the move-to-16.0 branch September 19, 2023 22:43
@eggrobin eggrobin mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedley nedley nedley approved these changes

@josh-hadley josh-hadley josh-hadley approved these changes

@Ken-Whistler Ken-Whistler Ken-Whistler left review comments

@echeran echeran Awaiting requested review from echeran

@Manishearth Manishearth Awaiting requested review from Manishearth

@srl295 srl295 Awaiting requested review from srl295

@eggrobin eggrobin Awaiting requested review from eggrobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusicu @srl295 @eggrobin @nedley @josh-hadley @Ken-Whistler