Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/minor test fixes #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2019
Merged

Feature/minor test fixes #1027

merged 3 commits into from
Nov 30, 2019

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Nov 30, 2019

Fixed test dependency on user running them - Resolves #969
Changed how savepoint name is generated - Resolves #982

@jgebal jgebal added this to the 3.1.10 milestone Nov 30, 2019
@PhilippSalvisberg
Copy link
Member

I'll have a look. Want to do some tests.

@PhilippSalvisberg
Copy link
Member

First of all, thank you very much @jgebal for identifying the problem causing wrong warnings and providing this fix.

I've installed the PR and it works.

However, I've preferred the old sequence based solution. The timestamp based solution has the risk that the same savepoint name could be generated and used. Right now this seems to be irrelevant, since utPLSQL is running sequentially and there is some processing before requesting another savepoint name. But theoretically it all depends on the speed of the database and the granularity of the timestamp provided by the OS (microseconds or nanoseconds). - I do not like to rely on slow processing ;-) - So personally I'd like to include a fix in a way I've outlined in #982 (comment) . But I can live with the way it is done right now.

Thanks!

@jgebal jgebal merged commit f7f9692 into develop Nov 30, 2019
@jgebal jgebal deleted the feature/minor_test_fixes branch December 1, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants