Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/minor test fixes #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2019
Merged

Feature/minor test fixes #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3973d0
Fixed test dependency on user running them.
jgebal Nov 29, 2019
39d144a
Changed how savepoint name is generated.
jgebal Nov 30, 2019
4bb7a95
Added a hash of owner to the generated savepoint name.
jgebal Nov 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/core/ut_savepoint_seq.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ create sequence ut_savepoint_seq
See the License for the specific language governing permissions and
limitations under the License.
*/
start with 1 cache 20;
start with 1 cache 20 minvalue 1 maxvalue 99999999999999999 cycle;
3 changes: 2 additions & 1 deletion source/core/ut_utils.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ create or replace package body ut_utils is
gc_invalid_first_xml_char constant varchar2(50) := '[^_a-zA-Z]';
gc_invalid_xml_char constant varchar2(50) := '[^_a-zA-Z0-9\.-]';
gc_full_valid_xml_name constant varchar2(50) := '^([_a-zA-Z])([_a-zA-Z0-9\.-])*$';
gc_owner_hash constant integer(11) := dbms_utility.get_hash_value( ut_owner(), 0, power(2,31)-1);

function surround_with(a_value varchar2, a_quote_char varchar2) return varchar2 is
begin
Expand Down Expand Up @@ -59,7 +60,7 @@ create or replace package body ut_utils is

function gen_savepoint_name return varchar2 is
begin
return 's'||trim(to_char(ut_savepoint_seq.nextval,'0000000000000000000000000000'));
return 's'||gc_owner_hash||trim(to_char(ut_savepoint_seq.nextval,'00000000000000000'));
end;

procedure debug_log(a_message varchar2) is
Expand Down
14 changes: 7 additions & 7 deletions test/ut3_tester/core/test_ut_suite.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ create or replace package body test_ut_suite is
l_suite ut3.ut_suite;
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite.path := 'ut3_tester_helper.ut_example_tests';
l_suite.disabled_flag := ut3.ut_utils.boolean_to_int(true);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'UT_EXAMPLE_TESTS', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite.after_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'UT_EXAMPLE_TESTS', 'add_1_to_g_number', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'UT_EXAMPLE_TESTS', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite.after_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'UT_EXAMPLE_TESTS', 'add_1_to_g_number', ut3.ut_utils.gc_before_all));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_EXAMPLE_TESTS',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_suite.items.extend;
Expand All @@ -44,9 +44,9 @@ create or replace package body test_ut_suite is
l_suite ut3.ut_suite;
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite.path := 'ut3_tester_helper.ut_example_tests';
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'UT_EXAMPLE_TESTS', 'failing_procedure', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'UT_EXAMPLE_TESTS', 'failing_procedure', ut3.ut_utils.gc_before_all));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'UT_EXAMPLE_TESTS',a_name => 'set_g_number_0', a_line_no=> 1);
--Act
Expand All @@ -65,9 +65,9 @@ create or replace package body test_ut_suite is
l_suite ut3.ut_suite;
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_EXAMPLE_TESTS', a_line_no=> 1);
l_suite.path := 'ut3_tester_helper.ut_example_tests';
l_suite.after_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'UT_EXAMPLE_TESTS', 'failing_procedure', ut3.ut_utils.gc_after_all));
l_suite.after_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'UT_EXAMPLE_TESTS', 'failing_procedure', ut3.ut_utils.gc_after_all));

l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_EXAMPLE_TESTS',a_name => 'set_g_number_0', a_line_no=> 1);
Expand Down
60 changes: 30 additions & 30 deletions test/ut3_tester/core/test_ut_test.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ create or replace package body test_ut_test is
--Arrange
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.path := 'ut3_tester_helper.ut_example_tests';
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));

l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
Expand All @@ -38,11 +38,11 @@ create or replace package body test_ut_test is
--Arrange
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.path := 'ut3_tester_helper.ut_example_tests';
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));

l_test := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_before_test));
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_after_test));
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_before_test));
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_after_test));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := l_test;
l_suite.items.extend;
Expand All @@ -65,10 +65,10 @@ create or replace package body test_ut_test is
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_test := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_before_each));
l_test.after_each_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_after_each));
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_before_each));
l_test.after_each_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_after_each));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := l_test;
l_suite.items.extend;
Expand All @@ -90,11 +90,11 @@ create or replace package body test_ut_test is
l_test ut3.ut_test;
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_test := ut3.ut_test(a_object_owner =>'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_before_test));
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_test));
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_before_test));
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_test));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := l_test;
l_suite.items.extend;
Expand All @@ -116,15 +116,15 @@ create or replace package body test_ut_test is
l_test ut3.ut_test;
begin
--Arrange
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_test := ut3.ut_test(a_object_owner => USER,a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_before_each));
l_test.after_each_list := ut3.ut_executables(ut3.ut_executable(USER, 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_each));
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_example_tests', a_line_no=> 1);
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_all));
l_test := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'failing_procedure', ut3.ut_utils.gc_before_each));
l_test.after_each_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_each));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := l_test;
l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => USER,a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper',a_object_name => 'ut_example_tests',a_name => 'add_1_to_g_number', a_line_no=> 1);
--Act
l_suite.do_execute();
--Assert
Expand All @@ -148,8 +148,8 @@ create or replace package body test_ut_test is
begin
l_test.after_each_list := ut3.ut_executables(
ut3.ut_executable(
user,
'UT_EXAMPLE_TESTS',
'ut3_tester_helper',
'ut_example_tests',
'add_1_to_g_number',
ut3.ut_utils.gc_after_each
)
Expand All @@ -171,7 +171,7 @@ create or replace package body test_ut_test is
);
begin
l_test.after_each_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_after_each)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_after_each)
);
--Act
l_test.do_execute();
Expand All @@ -190,7 +190,7 @@ create or replace package body test_ut_test is
);
begin
l_test.after_each_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', null, ut3.ut_utils.gc_after_each)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', null, ut3.ut_utils.gc_after_each)
);
--Act
l_test.do_execute();
Expand Down Expand Up @@ -325,7 +325,7 @@ create or replace package body test_ut_test is
a_line_no => null
);
begin
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable(user, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_each));
l_test.before_each_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_each));
--Act
l_test.do_execute();
--Assert
Expand All @@ -344,7 +344,7 @@ create or replace package body test_ut_test is
);
begin
l_test.before_each_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_before_each)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_before_each)
);
--Act
l_test.do_execute();
Expand All @@ -363,7 +363,7 @@ create or replace package body test_ut_test is
);
begin
l_test.before_each_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', null, ut3.ut_utils.gc_before_each)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', null, ut3.ut_utils.gc_before_each)
);
--Act
l_test.do_execute();
Expand Down Expand Up @@ -529,7 +529,7 @@ create or replace package body test_ut_test is
a_line_no => null
);
begin
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable(user, 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_test));
l_test.before_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'set_g_number_0', ut3.ut_utils.gc_before_test));
--Act
l_test.do_execute();
--Assert
Expand All @@ -547,7 +547,7 @@ create or replace package body test_ut_test is
);
begin
l_test.before_test_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_before_test)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'invalid setup name', ut3.ut_utils.gc_before_test)
);
--Act
l_test.do_execute();
Expand All @@ -566,7 +566,7 @@ create or replace package body test_ut_test is
);
begin
l_test.before_test_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', null, ut3.ut_utils.gc_before_test)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', null, ut3.ut_utils.gc_before_test)
);
--Act
l_test.do_execute();
Expand All @@ -584,7 +584,7 @@ create or replace package body test_ut_test is
a_line_no => null
);
begin
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable(user, 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_test));
l_test.after_test_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'add_1_to_g_number', ut3.ut_utils.gc_after_test));
--Act
l_test.do_execute();
--Assert
Expand All @@ -602,7 +602,7 @@ create or replace package body test_ut_test is
);
begin
l_test.after_test_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', 'invalid procedure name', ut3.ut_utils.gc_after_test)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', 'invalid procedure name', ut3.ut_utils.gc_after_test)
);
--Act
l_test.do_execute();
Expand All @@ -621,7 +621,7 @@ create or replace package body test_ut_test is
);
begin
l_test.after_test_list := ut3.ut_executables(
ut3.ut_executable(user, 'ut_example_tests', null, ut3.ut_utils.gc_after_test)
ut3.ut_executable('ut3_tester_helper', 'ut_example_tests', null, ut3.ut_utils.gc_after_test)
);
--Act
l_test.do_execute();
Expand Down
6 changes: 3 additions & 3 deletions test/ut3_tester_helper/run_helper.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,11 +550,11 @@ create or replace package body run_helper is
begin
--Arrange
execute immediate 'delete from ut$test_table';
l_suite := ut3.ut_suite(a_object_owner => USER, a_object_name => 'UT_TRANSACTION_CONTROL', a_line_no=> 1);
l_suite := ut3.ut_suite(a_object_owner => 'ut3_tester_helper', a_object_name => 'UT_TRANSACTION_CONTROL', a_line_no=> 1);
l_suite.path := 'ut_transaction_control';
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable(USER, 'UT_TRANSACTION_CONTROL', 'setup', ut3.ut_utils.gc_before_all));
l_suite.before_all_list := ut3.ut_executables(ut3.ut_executable('ut3_tester_helper', 'UT_TRANSACTION_CONTROL', 'setup', ut3.ut_utils.gc_before_all));
l_suite.items.extend;
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => USER, a_object_name => 'ut_transaction_control',a_name => a_procedure_name, a_line_no=> 1);
l_suite.items(l_suite.items.last) := ut3.ut_test(a_object_owner => 'ut3_tester_helper', a_object_name => 'ut_transaction_control',a_name => a_procedure_name, a_line_no=> 1);
l_suite.set_rollback_type(a_rollback_type);

--Act
Expand Down