address #160#163
Merged
jgebal merged 2 commits intoutPLSQL:version3from Jan 17, 2017
Merged
Conversation
d49acd6 to
fa994a1
Compare
fa994a1 to
cb190e1
Compare
jgebal
reviewed
Jan 16, 2017
| l_expected_msg := ' ' || self.matcher_name || self.additional_info; | ||
| if self.expected_value_string is not null or self.expected_type is not null then | ||
| l_expected_msg := l_expected_msg || ' (expected value): '; | ||
| l_expected_msg := l_expected_msg || ' this: '; |
Member
There was a problem hiding this comment.
I'd remove ' this: ' from l_expected_msg, because we get report in format:
expected this: '<DEMO_DEPARTMENT>
<DEPT_NAME>HR</DEPT_NAME>
</DEMO_DEPARTMENT>
'(ut3.demo_department)
to equal this: '<DEMO_DEPARTMENT>
<DEPT_NAME>Sales</DEPT_NAME>
</DEMO_DEPARTMENT>
'(ut3.demo_department)
I think it would be better to have something like:
expected this: '<DEMO_DEPARTMENT>
<DEPT_NAME>HR</DEPT_NAME>
</DEMO_DEPARTMENT>
'(ut3.demo_department)
to equal : '<DEMO_DEPARTMENT>
<DEPT_NAME>Sales</DEPT_NAME>
</DEMO_DEPARTMENT>
'(ut3.demo_department)
jgebal
approved these changes
Jan 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed #160