Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added shortcuts to all the matchers#299

Merged
jgebal merged 12 commits intoutPLSQL:developfrom
Pazus:shortcuts
May 7, 2017
Merged

Added shortcuts to all the matchers#299
jgebal merged 12 commits intoutPLSQL:developfrom
Pazus:shortcuts

Conversation

@Pazus
Copy link
Copy Markdown
Member

@Pazus Pazus commented May 1, 2017

Touches #283

@Pazus Pazus self-assigned this May 1, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.1%) to 86.21% when pulling 8644316 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.1%) to 86.21% when pulling 8644316 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.1%) to 86.21% when pulling 8644316 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 88.768% when pulling 89358f0 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented May 1, 2017

Coverage Status

Coverage increased (+0.4%) to 88.768% when pulling 89358f0 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.5%) to 88.821% when pulling ec0bd42 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.5%) to 88.821% when pulling ec0bd42 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.5%) to 88.821% when pulling ec0bd42 on Pazus:shortcuts into d393dd0 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented May 2, 2017

Coverage Status

Coverage increased (+0.4%) to 88.821% when pulling 930efe1 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@jgebal
Copy link
Copy Markdown
Member

jgebal commented May 3, 2017

Will you be able to add the not_to shortcuts as well and update the documentation?

fixed docs/userguide/expectations.md
fixed examples
fixed tests
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 87.757% when pulling a6699b6 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 87.757% when pulling a6699b6 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 87.757% when pulling a6699b6 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

```sql
begin
ut.expect( 'the tested value' ).to_( equal('the expected value') );
ut.expect( 'the tested value' ).to_equal('the expected value');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep both styles in the documentation for completeness?

@@ -16,6 +16,8 @@ create or replace type ut_expectation_anydata under ut_expectation(
limitations under the License.
*/
overriding member procedure to_equal(self in ut_expectation_anydata, a_expected anydata, a_nulls_are_equal boolean := null),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add not_to_equal

overriding member procedure to_equal(self in ut_expectation_date, a_expected date, a_nulls_are_equal boolean := null),
member procedure to_be_between(self in ut_expectation_date, a_lower_bound date, a_upper_bound date)
member procedure to_be_between(self in ut_expectation_date, a_lower_bound date, a_upper_bound date),
member procedure to_be_greater_or_equal(self in ut_expectation_date, a_expected date),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add:
not_to_be_greater_or_equal
not_to_be_greater_than
not_to_be_less_than
not_to_be_less_or_equal

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont like the idea to add not_to_be_less_than cause its to_be_greater_or_equal etc.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though implemented it)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.4%) to 86.025% when pulling d116234 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.4%) to 86.025% when pulling d116234 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.4%) to 86.025% when pulling d116234 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2017

Coverage Status

Coverage decreased (-4.4%) to 84.056% when pulling 83f13b9 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling b861d82 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling b861d82 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling b861d82 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling cdb7a80 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling cdb7a80 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.5%) to 83.918% when pulling cdb7a80 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2017

Coverage Status

Coverage decreased (-3.06%) to 85.347% when pulling 1b9e81a on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.06%) to 85.347% when pulling 1b9e81a on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.06%) to 85.347% when pulling 1b9e81a on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.06%) to 85.347% when pulling 1b9e81a on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2017

Coverage Status

Coverage decreased (-0.5%) to 87.959% when pulling b5c8cbc on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 87.959% when pulling b5c8cbc on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2017

Coverage Status

Coverage decreased (-0.5%) to 87.959% when pulling b5c8cbc on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.5%) to 89.931% when pulling 5a6e5f1 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.5%) to 89.931% when pulling 5a6e5f1 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.5%) to 89.931% when pulling 5a6e5f1 on Pazus:shortcuts into 5aa1e17 on utPLSQL:develop.

@jgebal jgebal merged commit de9b5c1 into utPLSQL:develop May 7, 2017
@jgebal jgebal removed the in progress label May 7, 2017
@jgebal jgebal mentioned this pull request May 7, 2017
4 tasks
@Pazus Pazus deleted the shortcuts branch July 15, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants