Added shortcuts to all the matchers#299
Merged
jgebal merged 12 commits intoutPLSQL:developfrom May 7, 2017
Merged
Conversation
2 similar comments
1 similar comment
2 similar comments
Member
|
Will you be able to add the not_to shortcuts as well and update the documentation? |
fixed docs/userguide/expectations.md fixed examples fixed tests
2 similar comments
jgebal
reviewed
May 5, 2017
| ```sql | ||
| begin | ||
| ut.expect( 'the tested value' ).to_( equal('the expected value') ); | ||
| ut.expect( 'the tested value' ).to_equal('the expected value'); |
Member
There was a problem hiding this comment.
Could we keep both styles in the documentation for completeness?
jgebal
reviewed
May 5, 2017
| @@ -16,6 +16,8 @@ create or replace type ut_expectation_anydata under ut_expectation( | |||
| limitations under the License. | |||
| */ | |||
| overriding member procedure to_equal(self in ut_expectation_anydata, a_expected anydata, a_nulls_are_equal boolean := null), | |||
jgebal
reviewed
May 5, 2017
| overriding member procedure to_equal(self in ut_expectation_date, a_expected date, a_nulls_are_equal boolean := null), | ||
| member procedure to_be_between(self in ut_expectation_date, a_lower_bound date, a_upper_bound date) | ||
| member procedure to_be_between(self in ut_expectation_date, a_lower_bound date, a_upper_bound date), | ||
| member procedure to_be_greater_or_equal(self in ut_expectation_date, a_expected date), |
Member
There was a problem hiding this comment.
can you add:
not_to_be_greater_or_equal
not_to_be_greater_than
not_to_be_less_than
not_to_be_less_or_equal
Member
Author
There was a problem hiding this comment.
Dont like the idea to add not_to_be_less_than cause its to_be_greater_or_equal etc.
added not_to_be_true and not_to_be_false matchers
2 similar comments
2 similar comments
2 similar comments
2 similar comments
jgebal
approved these changes
May 6, 2017
1 similar comment
Refactored and added more tests.
2 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touches #283