-
Notifications
You must be signed in to change notification settings - Fork 5
Convert to Multi-Module Project #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First test then install. Also do it in the separate steps Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: ikolomi <[email protected]> Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Restore clean multi-module parent POM structure that was corrupted during rebase process. Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Publishing will be done via APIs, not through Maven plugin. Follows upstream commit 2aa63d4. Signed-off-by: Jeremy Parr-Pearson <[email protected]>
292e26e to
7a66434
Compare
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
e11ffa1 to
34e3bff
Compare
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
4 tasks
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
ikolomi
approved these changes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restructures into a multi-module Maven project with a parent POM. This follows other community Spring Data projects such as redisson and spring-data-jest.
srctospring-data-valkey/src.Closes #37.
Features
Implementation
🔍 The key changes are in:
README.mdfiles - The parent README is more of an introduction, child READMEs go into more technical detailpom.xmlfiles - All common dependencies and plugins, plus all versioing information, is in the parent POMci.ymlandrelease.yml) - Simply tests or packages the parent module, which will automatically build or package all the child modulesDEVELOPER.md- Goes over how a developer can build and test each of the modules, and other developer tasksNote that child modules can only inherit from a single parent, so had to manually add some dependencies and plugins from spring-data-parent to spring-data-valkey.
Testing
Completed:
./mvn clean installand./mvn clean test)What's Next
Update the CI release action to automatically sign and publish artifacts to Maven.