Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremyprime
Copy link
Collaborator

@jeremyprime jeremyprime commented Jan 12, 2026

Summary

Restructures into a multi-module Maven project with a parent POM. This follows other community Spring Data projects such as redisson and spring-data-jest.

⚠️ This will impact existing branches/PRs as it moves all files from src to spring-data-valkey/src.

Closes #37.

Features

  • Moved spring-data-valkey to its own module directory
  • Added parent module for consolidated dependency management and versioning (single version for all modules)
  • Updated/consolidated all READMEs to avoid duplication of information
  • Added a DEVELOPER guide that goes over building and testing the modules
  • Added Makefile targets to simplify running examples and performance tests

Implementation

🔍 The key changes are in:

  • All README.md files - The parent README is more of an introduction, child READMEs go into more technical detail
  • All pom.xml files - All common dependencies and plugins, plus all versioing information, is in the parent POM
  • CI actions (ci.yml and release.yml) - Simply tests or packages the parent module, which will automatically build or package all the child modules
  • Newly added DEVELOPER.md - Goes over how a developer can build and test each of the modules, and other developer tasks

Note that child modules can only inherit from a single parent, so had to manually add some dependencies and plugins from spring-data-parent to spring-data-valkey.

Testing

Completed:

  • spring-data-valkey and spring-boot-starter-data-valkey installation and unit tests (./mvn clean install and ./mvn clean test)
  • Ran all examples and performance tests
  • Tested both Makefile targets and individual execution of Maven modules
  • Tested release process still includes Spring Data Valkey and starter

What's Next

Update the CI release action to automatically sign and publish artifacts to Maven.

ikolomi and others added 13 commits January 12, 2026 10:56
First test then install. Also do it in the separate steps

Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: ikolomi <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Restore clean multi-module parent POM structure that was
corrupted during rebase process.

Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Publishing will be done via APIs, not through Maven plugin.
Follows upstream commit 2aa63d4.

Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
@jeremyprime jeremyprime reopened this Jan 12, 2026
@jeremyprime jeremyprime marked this pull request as ready for review January 12, 2026 20:56
@jeremyprime jeremyprime requested a review from ikolomi January 12, 2026 20:57
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
@ikolomi ikolomi added the enhancement New feature or request label Jan 18, 2026
@ikolomi ikolomi added this to the Beta 0.2.0 milestone Jan 18, 2026
@ikolomi ikolomi merged commit b96d020 into valkey-io:main Jan 18, 2026
23 checks passed
@jeremyprime jeremyprime deleted the multi-module branch January 19, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Project to be Multi-Module

2 participants