packages/language-service/src/injectTypes.ts (1)

42-47: String-replace on magic line is fragile

generateGlobalTypes() blindly replaces the exact string
type __VLS_Element = import('vue/jsx-runtime').JSX.Element;
If upstream @vue/language-core ever tweaks whitespace or semicolons, the replacement silently fails.

Guard with a regex or fallback:

globalTypes = globalTypes.replace(
  /type\s+__VLS_Element\s*=\s*import\('vue\/jsx-runtime'\)\.JSX\.Element\s*;/,
  'type __VLS_Element = import(\'vue/jsx-runtime\').JSX.Element & { [VUE_VINE_COMPONENT]: true };',
)

This makes updates less brittle.

packages/compiler/tests/validate.spec.ts (1)

276-283: Underlying compiler emits duplicate errors – consider de-duping instead of asserting twice

Updating the snapshot to expect two identical messages papers over a duplication bug in template validation. Prefer de-duplicating diagnostic emission so each unique issue is reported once, then keep the original single-error assertion.

packages/language-service/typescript-plugin/visitors.ts (3)

80-90: Centralise magic string __VLS_VINE_ComponentsReferenceMap.

The same identifier is handcrafted here and in virtual-code generation. A future rename will break the linkage again – move it to a shared constant (e.g. src/constants.ts) and import from both places.

---

120-130: Hard-coded __VLS_IntrinsicElements deserves a shared constant.

For the same maintainability reason as above, lift the string into a common constant to avoid accidental divergence.

---

160-170: Ditto for __VLS_directives.

Re-use a constant rather than three separate literals introduced in this PR.

packages/compiler/src/index.ts (1)

175-219: Heavy duplication between compileVineTypeScriptFile & analyzeVineTypeScriptFile.

The new analyse-only path repeats ~80 % of the earlier function. Extract the shared steps (bind ctx, validate, analyse, optional template-compile loop) into an internal helper to keep the surface DRY and easier to evolve.

packages/language-service/src/virtual-code.ts (1)

7-10: Rename import to avoid shadowing global toString.

import { toString } from 'muggle-string' shadows the intrinsic Object.prototype.toString, which can trip up stack-traces and debuggers.

-import { toString } from 'muggle-string'
+import { toString as muggleToString } from 'muggle-string'

and adjust later usages.

packages/compiler/src/template/compose.ts (1)

356-362: hasTemplateCompileErr is never written

The flag is declared but never set, so the subsequent check is dead code:

let hasTemplateCompileErr = false
...
if (hasTemplateCompileErr) { ... }

Drop the variable or wire it to the error callback to avoid misleading intent.

packages/language-service/src/codegen.ts (1)

368-376: In-place sort mutates shared array

macrosInfoForVolar.sort(...) re-orders the original array held by the compiler context.
If the same array is read elsewhere later the order change may cause subtle bugs.

Use a cloned array to keep this function side-effect-free:

-  vineCompFn.macrosInfoForVolar
-    // Sort by AST node start position
-    .sort(...)
+  [...vineCompFn.macrosInfoForVolar]
+    .sort(...)

packages/language-service/src/injectTypes.ts (3)

54-60: Avoid code-duplication: alias to the existing helpers instead of re-copying their bodies

__VLS_VINE_StrictIsAny and __VLS_VINE_OmitAny duplicate the full definition already present for __VLS_StrictIsAny / __VLS_OmitAny.
Keeping two divergent copies is maintenance-heavy and easy to let drift.

-type __VLS_VINE_StrictIsAny<T> = [unknown] extends [T]
-  ? ([T] extends [unknown] ? true : false)
-  : false;
-
-type __VLS_VINE_OmitAny<T> = {
-  [K in keyof T as __VLS_VINE_StrictIsAny<T[K]> extends true ? never : K]: T[K]
-}
+type __VLS_VINE_StrictIsAny<T> = __VLS_StrictIsAny<T>;
+type __VLS_VINE_OmitAny<T>   = __VLS_OmitAny<T>;

Same behaviour, one source of truth.

---

60-64: __VLS_VINE_CreateVineVLSCtx is type-only – make that explicit

Mark the helper with declare const (or put it in an interface) to avoid accidental value-side emission when the .d.ts is re-used outside the LS.

-const __VLS_VINE_CreateVineVLSCtx: <T>(ctx: T) => __VLS_VINE_MakeVLSCtx<import('vue').ShallowUnwrapRef<T>>;
+declare const __VLS_VINE_CreateVineVLSCtx: <T>(
+  ctx: T,
+) => __VLS_VINE_MakeVLSCtx<import('vue').ShallowUnwrapRef<T>>;

This keeps the helper purely ambient.

---

68-75: Nit: helper-type names now exceed 30 chars

__VLS_VINE_RecordToUnion / __VLS_VINE_UnionToIntersection push IDE tooltips off-screen.
Consider shortening the prefix (e.g. __VV_) – they are already unique.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : 在 `.vine.ts` 文件中，所有函数只要满足条件：“返回值是一个 tagged template string 且标签名必须是 `vine` 的字符串”，都将被视为一个组件函数

Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : Vine 仅会处理文件名后缀为 `.vine.ts` 的文件

Learnt from: ShenQingchuan
PR: vue-vine/vue-vine#283
File: packages/vscode-ext/package.json:105-110
Timestamp: 2025-06-17T14:54:18.385Z
Learning: The Vue Vine VSCode extension uses tsdown as a bundler that statically analyzes and includes all imported dependencies in the final bundle, regardless of whether they are listed in dependencies or devDependencies in packages/vscode-ext/package.json. Runtime dependencies can safely be placed in devDependencies since they will be bundled into the extension output.

Learnt from: ShenQingchuan
PR: vue-vine/vue-vine#265
File: packages/compiler/src/template/transform-negative-bool.ts:13-14
Timestamp: 2025-05-26T13:09:15.829Z
Learning: In Vue Vine codebase, prefer using hardcoded numeric values with the `satisfies` operator (e.g., `(6 satisfies NodeTypes.ATTRIBUTE)`) instead of direct enum references. This reduces production bundle size by avoiding enum object embedding while maintaining TypeScript type checking functionality.

Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : 在 `.vine.ts` 文件中，所有函数只要满足条件：“返回值是一个 tagged template string 且标签名必须是 `vine` 的字符串”，都将被视为一个组件函数

Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : Vine 仅会处理文件名后缀为 `.vine.ts` 的文件

Learnt from: ShenQingchuan
PR: vue-vine/vue-vine#283
File: packages/vscode-ext/package.json:105-110
Timestamp: 2025-06-17T14:54:18.385Z
Learning: The Vue Vine VSCode extension uses tsdown as a bundler that statically analyzes and includes all imported dependencies in the final bundle, regardless of whether they are listed in dependencies or devDependencies in packages/vscode-ext/package.json. Runtime dependencies can safely be placed in devDependencies since they will be bundled into the extension output.

Learnt from: ShenQingchuan
PR: vue-vine/vue-vine#265
File: packages/compiler/src/template/transform-negative-bool.ts:13-14
Timestamp: 2025-05-26T13:09:15.829Z
Learning: In Vue Vine codebase, prefer using hardcoded numeric values with the `satisfies` operator (e.g., `(6 satisfies NodeTypes.ATTRIBUTE)`) instead of direct enum references. This reduces production bundle size by avoiding enum object embedding while maintaining TypeScript type checking functionality.