test: upgrade to vitest v4 #5141

9romise · 2025-11-04T01:13:06Z

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Read the Pull Request Guidelines.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

CI is failing in the useFetch tests. It seems related to vitest and has been fixed in vitest v4, see: vitest-dev/vitest#8374

Additional context

#5138 (comment)

https://vitest.dev/guide/migration.html#browser-provider-rework

9romise · 2025-11-04T01:15:58Z

Typecheck failures in CI should be fixed by #5138.

pkg-pr-new · 2025-11-04T08:00:41Z

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5141

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5141

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5141

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5141

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5141

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5141

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5141

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5141

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5141

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5141

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5141

commit: 67f4474

package.json

userquin · 2025-11-04T12:31:43Z

can you fix lockfile? run pnpm dedupe, maybe we should add rolldown-vite to resolutions at root package.json (replace vitepress>vite entry with just vite in the key)

9romise · 2025-11-04T12:35:41Z

can you fix lockfile? run pnpm dedupe, maybe we should add rolldown-vite to resolutions at root package.json (replace vitepress>vite entry with just vite in the key)

I think we can merge #5138 first.

userquin · 2025-11-04T14:32:14Z

this looks better, run test script from root and update the tests (press u once tests finish running if vitest running in watch mode)

9romise · 2025-11-04T14:53:18Z

The test errors aren't related to snapshots. They seem to be caused by upstream changes. I'm also looking into solutions.
Thanks a lot for your help and tracking!

userquin · 2025-11-05T11:14:06Z

Looks like we've a regression in jsdom, try pinning jsdom to 20.0.3: vitest-dev/vitest#8017 (comment)

9romise · 2025-11-05T11:36:46Z

Looks like we've a regression in jsdom, try pinning jsdom to 20.0.3: vitest-dev/vitest#8017 (comment)

This issue doesn't seem directly related to our problem — it reports incorrect return values, while we're encountering getComputedStyle being undefined.
I suspect it might be related to cb8ec13 (#5141). Let's give it a try. CI looks like it's all passed now.

codecov · 2025-11-05T11:37:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.63%. Comparing base (0176d64) to head (0c61838).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5141      +/-   ##
==========================================
- Coverage   67.71%   63.63%   -4.09%     
==========================================
  Files         367      345      -22     
  Lines       14721     7853    -6868     
  Branches     2456     2426      -30     
==========================================
- Hits         9968     4997    -4971     
+ Misses       4742     2312    -2430     
- Partials       11      544     +533

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

9romise · 2025-11-05T11:37:55Z

packages/.test/index.ts

@@ -1,7 +1,3 @@
-import process from 'node:process'
-
-export const isBelowNode18 = Number(process.version.slice(1).split('.')[0]) < 18


We don't run CI on Node18 now.

packages/core/useScroll/index.ts

9romise · 2025-11-05T11:39:35Z

packages/core/useWindowSize/index.test.ts

-    removeEventListener: vi.fn(),
-    dispatchEvent: vi.fn(),
-  }))
+  const matchMediaSpy = vi.spyOn(window, 'matchMedia')


Should I mock matchMedia globally or move this file to browser.test.ts?

9romise · 2025-11-05T11:42:39Z

It looks like there's an issue with the test coverage. I'll take a look.

userquin · 2025-11-05T12:26:13Z

why codecov still with previous old run here #5141 (comment)?

9romise · 2025-11-05T12:34:13Z

It is still failing, the coverage files are empty.

9romise · 2025-11-05T14:37:18Z

vitest.config.ts

          include: [
-            '!packages/**/*.{browser,server}.{test,spec}.ts',
            'packages/**/*.{test,spec}.ts',
            'test/*.{test,spec}.ts',
          ],
+          exclude: [
+            'packages/**/*.{browser,server}.{test,spec}.ts',
+          ],


Finally! The coverage failure was caused by this line, which relates to vitest's migration of coverage calculation from test-exclude to picomatch. I haven't looked into it deeply for now, but if I get the chance, I'll open an issue or PR for vitest.

yeah, Vitest should have added a fix => move all include entries that begin with ! to the exclude

This reverts commit cb8ec13.

9romise · 2025-11-05T14:55:33Z

The tests are still failing due to getComputedStyle, and the issue isn't consistently reproducible. 😕

userquin · 2025-11-05T15:52:32Z

The tests are still failing due to getComputedStyle, and the issue isn't consistently reproducible. 😕

cannot pin jsdom to 20.0.3?

9romise · 2025-11-05T16:08:42Z

The tests are still failing due to getComputedStyle, and the issue isn't consistently reproducible. 😕

cannot pin jsdom to 20.0.3?

Yes, this didn't resolve the issue and even introduced more errors. See https://github.com/vueuse/vueuse/actions/runs/19108005315/job/54597101035?pr=5141

userquin · 2025-11-05T16:19:29Z

Yes, this didn't resolve the issue and even introduced more errors

arggg, I'll check it in ~ 1 hour 🤞

9romise · 2025-11-05T16:24:37Z

While the tests are passing after bumping jsdom to 27.1.0 now, but I suspect the underlying issue hasn't actually been fixed. 🤔

9romise added 3 commits October 31, 2025 14:10

feat: update to vitest 4

a077d55

chore: update vitest/browser

85643f0

chore: remove types

8aa2c65

https://vitest.dev/guide/migration.html#browser-provider-rework

Merge branch 'main' into vitest

f5f2cbc

userquin reviewed Nov 4, 2025

View reviewed changes

package.json Show resolved Hide resolved

chore: run pnpm dedupe, try fix ci

5516c3f

9romise added 5 commits November 5, 2025 16:42

test: mock matchMedia

1c7a2f1

chore: update vitest

799919e

test: fix

d907fb4

Merge branch 'main' into vitest

7f00fe6

chore: remove isBelowNode18

3b00321

9romise added 2 commits November 5, 2025 19:23

fix: dont update msw now

400f0bd

ci: try fix

cb8ec13

9romise marked this pull request as ready for review November 5, 2025 11:36

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Nov 5, 2025

9romise commented Nov 5, 2025

View reviewed changes

packages/core/useScroll/index.ts Outdated Show resolved Hide resolved

9romise commented Nov 5, 2025

View reviewed changes

9romise marked this pull request as draft November 5, 2025 11:41

ci: try fix coverage

63aa861

test: fix coverage

8a1674f

9romise commented Nov 5, 2025

View reviewed changes

Revert "ci: try fix"

1d9c1f7

This reverts commit cb8ec13.

9romise added 2 commits November 5, 2025 23:56

fix: pin jsdom to 20.0.3

95228f5

chore: bump jsdom

4fb1fbe

9romise added 2 commits November 6, 2025 09:05

chore: improve coverage

0c61838

ci: improve coverage

67f4474

		@@ -1,7 +1,3 @@
		import process from 'node:process'

		export const isBelowNode18 = Number(process.version.slice(1).split('.')[0]) < 18

Uh oh!

test: upgrade to vitest v4 #5141

Are you sure you want to change the base?

test: upgrade to vitest v4 #5141

Conversation

9romise commented Nov 4, 2025

Before submitting the PR, please make sure you do the following

Description

Additional context

Uh oh!

9romise commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

userquin commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

9romise commented Nov 4, 2025

Uh oh!

userquin commented Nov 4, 2025

Uh oh!

9romise commented Nov 4, 2025

Uh oh!

userquin commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

9romise commented Nov 5, 2025

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

9romise Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

9romise Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

9romise commented Nov 5, 2025

Uh oh!

userquin commented Nov 5, 2025

Uh oh!

9romise commented Nov 5, 2025

Uh oh!

9romise Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

userquin Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

9romise commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

userquin commented Nov 5, 2025

Uh oh!

9romise commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

userquin commented Nov 5, 2025

Uh oh!

9romise commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

9romise commented Nov 4, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 4, 2025 •

edited

Loading

userquin commented Nov 4, 2025 •

edited

Loading

userquin commented Nov 5, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading

userquin Nov 5, 2025 •

edited

Loading

9romise commented Nov 5, 2025 •

edited

Loading

9romise commented Nov 5, 2025 •

edited

Loading