Review Comments#247
Closed
egekorkan wants to merge 584 commits into
Closed
Conversation
* SecurityScheme: rename proxyURI to proxy * Rename APIKeySecurityScheme to ApikeySecurityScheme * BearerSecurityScheme: add attribute authorization * CertSecurityScheme: missing * Rename PskScheme to PSKSecurityScheme and add attribute identity * PublicSecurityScheme: missing * Rename PopSecurityScheme to PoPSecurityScheme * OAuth2SecurityScheme: add attributes token and refresh
change writable to readOnly and writeOnly add MultiLanguage term for titles and descriptions add safe and idempotent to Action
…curity) in Form Interface add required ExpectedResponse interface
… add base, lastModified, ..
Signed-off-by: Zoltan Kis <[email protected]>
Add appendix for WebIDL index
…ent (TypeScript definitions)
…()/write() and action.invoke() (e.g., for uriVariables)
added 2 commits
September 14, 2020 17:25
Signed-off-by: Zoltan Kis <[email protected]>
Update README and rationale
Fix #258: improve expose() algorithm
Fix #244: ConsumeThing constructor and consume() should do the same
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Now ts definition file supports both module and no module system environments.
added 2 commits
September 23, 2020 15:15
Signed-off-by: Zoltan Kis <[email protected]>
Fix ReSpec header with new group field
Proposal for typescript definition file
Fix typescript definition module name
add "target": "es6"
Contributor
|
@egekorkan do you want to take a look at the last version and check whether all aspects are integrated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed http://astrofrog.github.io/blog/2013/04/10/how-to-conduct-a-full-code-review-on-github/
We can use this for discussions
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Sep 25, 2020, 12:00 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.