example review file for commenting the spec#248
Closed
zolkis wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Zoltan Kis <[email protected]>
Closed
Contributor
Author
|
I am closing this for now, but anyone interested on a full text review of the spec (or any other file), please follow similar steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example how make a full review on the spec.
Copy index.html to this directory and rename it to your-name.
It appears as a new file in the PR and people can comment on any line of it.
Signed-off-by: Zoltan Kis [email protected]