Pe 11 12 18 - #5
Merged
Merged
Conversation
Member
|
PR looks good, didn't see any issues with the code. This PR looks like a good place to also add the font family as well -- Set to "JetBrains Mono". Want to add that in before we merge? |
xxyy2024
pushed a commit
to xxyy2024/waveterm_aipy
that referenced
this pull request
Jun 24, 2025
Preview Directory
sawka
added a commit
that referenced
this pull request
Feb 5, 2026
…2825) * Track wave version when job was created (for future backward compat) * New Flyover Menu off of "shell durability" icon. Help + Actions + UX * Bug with conn typeahead not closing when clicking disconnect * Auto-reconnect jobs that have been disconnected (check for "gone" state) * Disable tab indicator stuff (only indicates tab not block) * Fix bug with dev logging path on connserver * Fix bugs with restarting blockcontrollers on startup * Fix bugs with getting HasExited status from job manager * Fix startup files, quoting, tilde, etc in start job flow * ...
kaeltran16
pushed a commit
to kaeltran16/waveterm
that referenced
this pull request
Jul 17, 2026
First tranche of Theme 4 (maintainability & test gaps), executed on current main after Theme 1 and Theme 3 landed. Test-gaps (characterization; each mutation-verified): - runactions.test.ts — confirmCancelRun live-worker branch/copy, cancelRun + stopRunWorker in-flight tracking and finally-cleanup, tab: strip. - agentcwdresolve.test.ts — resolveCwd block->tail->head precedence; head read fires only on a tail miss; null at the error boundary. - pkg/jarvis/watcher_test.go + onexit_test.go — extracted pure predicates askAutoAnswerable (single single-select pre-filter) and optionIndexInRange (delivery bounds guard) from handleAsk (behavior-preserving) and tested them; outcomeSummary last-event-vs-task + 160-char truncation. wavetermdev#2 was unblocked by Theme 3 A1 (dac43d1). Refactor wavetermdev#6 (behavior-preserving): - findSessionTermBlock pure selector added to sessionviewmodel.ts; all 4 duplicate "first term block with cmd:cwd" sites in sessionsidebarmodel.ts routed through it via a resolveTabBlocks id-resolver. Deferred: wavetermdev#4 (runbody.tsx split) and wavetermdev#5 (agentsviewmodel.ts grid extract) -- pending the active Theme 2 work that edits those files. Verified: vitest run (1138 pass), large-stack tsc (clean), go test ./pkg/jarvis/ (ok), go vet clean.
kaeltran16
pushed a commit
to kaeltran16/waveterm
that referenced
this pull request
Jul 17, 2026
kaeltran16
pushed a commit
to kaeltran16/waveterm
that referenced
this pull request
Jul 20, 2026
Work through docs/open-issues.md; wavetermdev#5 deferred (documented blocker). wavetermdev#1 gitattributes merge=union for the three generated wshrpc client files (wshclient.go, wshclientapi.ts, gotypes.d.ts); tsgen guards backstop a bad union. wavetermdev#2 split two agent-view god-files (move-only, call sites unchanged): - runbody.tsx 881->561: card family -> runcards.tsx, plan editor -> planpreview.tsx - agentsviewmodel.ts 1030->895: grid geometry -> cardgridlayout.ts (+ tests), re-exported so importers are untouched. wavetermdev#3 (3a) transcript-stream per-card unmount watcher leak: - server cancelRequest now cancels the request context (not just the bool), so a streaming handler's goroutine + fsnotify watcher unwind while the link is up. - client emits the wire cancel synchronously from an overridden return() in sendRpcCommand -- gen.return() hangs and never runs finally when the generator is parked at the never-settling await (a quiet stream), so a finally-based cancel would be missed. Guarded by go -race + client vitest. - 3b (stateful projection) intentionally not built (measure-first). wavetermdev#4 channel-attachment temp-file cleanup: WriteTempFileCommand now uses a distinct waveterm-attach- prefix (the bare waveterm- sweep could delete /tmp/waveterm-<uid> socket dirs on Linux/macOS); SweepTempAttachments reaps dirs >24h, wired into wavesrv startup + a 4h loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on the following: