Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PE-53 49 - #6

Closed
anandamarsh wants to merge 3 commits into
mainfrom
PE_53_49
Closed

PE-53 49#6
anandamarsh wants to merge 3 commits into
mainfrom
PE_53_49

Conversation

@anandamarsh

Copy link
Copy Markdown

No description provided.

@anandamarsh
anandamarsh requested a review from sawka August 30, 2023 23:01
@sawka

sawka commented Sep 1, 2023

Copy link
Copy Markdown
Member

looks pretty good.

need to add the mobx.action(() => {...})(); calls to prevent warnings. also need to remove the console.log statements now that it's going to main.

@anandamarsh

Copy link
Copy Markdown
Author

If you are fine with rest of the changes, close this PR without merging. I am working on another PR (PE_10) which is ahead of this branch.

@sawka

sawka commented Sep 1, 2023

Copy link
Copy Markdown
Member

no problem, whatever works best for you

@sawka sawka changed the title Pe 53 49 PE-53 49 Sep 1, 2023
@anandamarsh anandamarsh closed this Sep 1, 2023
@anandamarsh
anandamarsh deleted the PE_53_49 branch September 20, 2023 00:12
xxyy2024 pushed a commit to xxyy2024/waveterm_aipy that referenced this pull request Jun 24, 2025
kaeltran16 pushed a commit to kaeltran16/waveterm that referenced this pull request Jul 17, 2026
First tranche of Theme 4 (maintainability & test gaps), executed on current
main after Theme 1 and Theme 3 landed.

Test-gaps (characterization; each mutation-verified):
- runactions.test.ts — confirmCancelRun live-worker branch/copy, cancelRun +
  stopRunWorker in-flight tracking and finally-cleanup, tab: strip.
- agentcwdresolve.test.ts — resolveCwd block->tail->head precedence; head read
  fires only on a tail miss; null at the error boundary.
- pkg/jarvis/watcher_test.go + onexit_test.go — extracted pure predicates
  askAutoAnswerable (single single-select pre-filter) and optionIndexInRange
  (delivery bounds guard) from handleAsk (behavior-preserving) and tested them;
  outcomeSummary last-event-vs-task + 160-char truncation. wavetermdev#2 was unblocked by
  Theme 3 A1 (dac43d1).

Refactor wavetermdev#6 (behavior-preserving):
- findSessionTermBlock pure selector added to sessionviewmodel.ts; all 4
  duplicate "first term block with cmd:cwd" sites in sessionsidebarmodel.ts
  routed through it via a resolveTabBlocks id-resolver.

Deferred: wavetermdev#4 (runbody.tsx split) and wavetermdev#5 (agentsviewmodel.ts grid extract) --
pending the active Theme 2 work that edits those files.

Verified: vitest run (1138 pass), large-stack tsc (clean), go test
./pkg/jarvis/ (ok), go vet clean.
kaeltran16 pushed a commit to kaeltran16/waveterm that referenced this pull request Jul 21, 2026
…t-scan brief

open-issues.md: add issue wavetermdev#6 (sealed Run-Evidence card, 6a/6b/6c). briefs: 2026-07-21 open-ended improvement-scan candidate backlog (its finding A3 is the read-pool work just landed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants