PE-53 49 - #6
Closed
anandamarsh wants to merge 3 commits into
Closed
Conversation
Member
|
looks pretty good. need to add the mobx.action(() => {...})(); calls to prevent warnings. also need to remove the console.log statements now that it's going to main. |
Author
|
If you are fine with rest of the changes, close this PR without merging. I am working on another PR (PE_10) which is ahead of this branch. |
Member
|
no problem, whatever works best for you |
xxyy2024
pushed a commit
to xxyy2024/waveterm_aipy
that referenced
this pull request
Jun 24, 2025
kaeltran16
pushed a commit
to kaeltran16/waveterm
that referenced
this pull request
Jul 17, 2026
First tranche of Theme 4 (maintainability & test gaps), executed on current main after Theme 1 and Theme 3 landed. Test-gaps (characterization; each mutation-verified): - runactions.test.ts — confirmCancelRun live-worker branch/copy, cancelRun + stopRunWorker in-flight tracking and finally-cleanup, tab: strip. - agentcwdresolve.test.ts — resolveCwd block->tail->head precedence; head read fires only on a tail miss; null at the error boundary. - pkg/jarvis/watcher_test.go + onexit_test.go — extracted pure predicates askAutoAnswerable (single single-select pre-filter) and optionIndexInRange (delivery bounds guard) from handleAsk (behavior-preserving) and tested them; outcomeSummary last-event-vs-task + 160-char truncation. wavetermdev#2 was unblocked by Theme 3 A1 (dac43d1). Refactor wavetermdev#6 (behavior-preserving): - findSessionTermBlock pure selector added to sessionviewmodel.ts; all 4 duplicate "first term block with cmd:cwd" sites in sessionsidebarmodel.ts routed through it via a resolveTabBlocks id-resolver. Deferred: wavetermdev#4 (runbody.tsx split) and wavetermdev#5 (agentsviewmodel.ts grid extract) -- pending the active Theme 2 work that edits those files. Verified: vitest run (1138 pass), large-stack tsc (clean), go test ./pkg/jarvis/ (ok), go vet clean.
kaeltran16
pushed a commit
to kaeltran16/waveterm
that referenced
this pull request
Jul 21, 2026
…t-scan brief open-issues.md: add issue wavetermdev#6 (sealed Run-Evidence card, 6a/6b/6c). briefs: 2026-07-21 open-ended improvement-scan candidate backlog (its finding A3 is the read-pool work just landed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.