Add LD_RUNPATH_SEARCH_PATHS to extensionkit-extension preset#1255
Open
alessionossa wants to merge 1 commit intoyonaskolb:masterfrom
Open
Add LD_RUNPATH_SEARCH_PATHS to extensionkit-extension preset#1255alessionossa wants to merge 1 commit intoyonaskolb:masterfrom
alessionossa wants to merge 1 commit intoyonaskolb:masterfrom
Conversation
Collaborator
|
I started thinking it also should be fixed by XcodeProj (yes, this pr also should be okay), could you check it if you have time? |
freddi-kit
approved these changes
Sep 6, 2022
Author
@freddi-kit I see that |
Owner
|
Thanks @alessionossa. Could you add a changelog entry as well please. And at the moment we aren't using the BuildSettingsProvider from XcodeProj, as that didn't exist at the time. I've created a new issue to track that here #1267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
LD_RUNPATH_SEARCH_PATHSoption as it is for other types of extensions (e.g. app extension).I followed the same logic of #272, copying the value from the current version of SettingPresets/Products/app-extension.yml