Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox#5562

Merged
weierophinney merged 2 commits into
zendframework:developfrom
bacinsky:feature/select_and_multicheckbox_unset_value_option
Mar 4, 2014
Merged

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox#5562
weierophinney merged 2 commits into
zendframework:developfrom
bacinsky:feature/select_and_multicheckbox_unset_value_option

Conversation

@bacinsky
Copy link
Copy Markdown
Contributor

@bacinsky bacinsky commented Dec 2, 2013

It could be nice to have such a method to remove a value option from a form element in runtime.

Instead of this in the user land:

$valueOptions = $element->getValueOptions();
if (isset($valueOptions['something'])) {
    unset($valueOptions['something']);
    $element->setValueOptions($valueOptions);
}

just this:

$element->unsetValueOption('something');

@samsonasik
Copy link
Copy Markdown
Contributor

samsonasik commented Dec 1, 2013

+1

samsonasik
samsonasik reviewed Dec 3, 2013
View reviewed changes
Comment thread library/Zend/Form/Element/MultiCheckbox.php Outdated
Copy link
Copy Markdown
Contributor

@samsonasik samsonasik Dec 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return self

@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Jan 2, 2014

@bacinsky Please send a PR to zf2-documentation too

@bacinsky bacinsky mentioned this pull request Jan 4, 2014
Closed
@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014
@weierophinney weierophinney self-assigned this Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
Merge pull request #5562 from bacinsky/feature/select_and_multicheckb…
6205589 
…ox_unset_value_option

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
Merge branch 'feature/5562' into develop
4a2d96a 
Close #5562
@weierophinney weierophinney merged commit 1852f28 into zendframework:develop Mar 4, 2014
@bacinsky bacinsky deleted the feature/select_and_multicheckbox_unset_value_option branch March 4, 2014 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weierophinney weierophinney

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bacinsky @samsonasik @Maks3w @weierophinney