This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix for odd php-cs-fixer finds#6462
Closed
chadicus wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 15, 2014
Member
|
For me the dry run fails with this only:
|
Member
|
I don't think you should fix errors which aren't any. Make an issue report against PHP-CS-Fixer, but eventually, we switch to PHPCS anyway I suppose. |
Contributor
Author
|
I was doing this so developers' builds would stop failing. The noise that these failures generates distracts from actual failures within a pull request. |
Member
|
Well, then the correct approach is to get rid of the buggy php-cs-fixer ;) |
Contributor
Author
|
Started down that route after I saw @localheinz PR #6182. I added my own PR #6454 |
Contributor
Author
|
Feel free to close this PR if you would rather wait until php-cs-fixer is gone |
Member
gianarb
pushed a commit
to zendframework/zend-tag
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-tag
that referenced
this pull request
May 15, 2015
…ted-errors' into develop Forward port zendframework/zendframework#6462
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…ted-errors' into develop Forward port zendframework/zendframework#6462
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
…ted-errors' into develop Forward port zendframework/zendframework#6462
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…ted-errors' into develop Forward port zendframework/zendframework#6462
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not know why
php-cs-fixerreported these errors, I'm assuming some character(s) within the files themselves caused some weird tokenizing.On a fresh clone of
zend/masterYou will get the following errorsMy solution for all of the
visibilityerrors was to move the methods within the class files.php-cs-fixersolution was to type-hint the methods withpublicresulting in