More "get rid of just-python invocation" #18284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not throughly tested, but seems to build. Someone with more knowledge of SDKs and such should check if they function. I believe stuff like Bockbuild may also need updates for this.
Member
|
Please do the shebang changes in a separate PR, because while the $(PYTHON) stuff looks good I'm not comfortable with the shebang changes |
f8e55c1 to
56e3597
Compare
kg
reviewed
Dec 23, 2019
|
|
||
| distdir: | ||
| distclean: | ||
| distclean: |
Contributor
Author
There was a problem hiding this comment.
My editor probably did this, sorry.
kg
approved these changes
Dec 23, 2019
Member
|
@monojenkins build pkg |
Member
|
@monojenkins build OS X Extended |
lambdageek
previously requested changes
Dec 27, 2019
Member
lambdageek
left a comment
There was a problem hiding this comment.
This is ok, actually. Just want to block the merge until the extra CI lanes are done. Dismiss me when they're green.
alexischr
approved these changes
Dec 27, 2019
Contributor
|
@monojenkins build OS X Extended |
akoeplinger
approved these changes
Jan 7, 2020
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
Commit migrated from mono/mono@b3ce5bf
akoeplinger
pushed a commit
to monojenkins/mono
that referenced
this pull request
Apr 2, 2020
(cherry picked from commit b3ce5bf)
akoeplinger
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Force Python 3.x from env in shebang lines * Fix byte/string incompatiblity in Python 3 * Fix locating Python interpreter when it isn't "python" (#18197) Fix locating Python interpreter when it isn't "python" The "python" interpreter is specified by PEP-394. In it, an OS can decide not to ship a "python" executable, and instead only ship python2/3, providing some ambiguity for scripts that are version-neutral, like the one Mono uses. This uses an automake macro to locate a suitable Python, and changes the makefile to use the located Python, whatever it may be. (cherry picked from commit 84221f0) * More disambiguation of Python in makefiles (#18284) (cherry picked from commit b3ce5bf) * [build] Check for Python 3 in configure.ac (#18625) I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2). (cherry picked from commit 0f47ea5) Co-authored-by: Calvin Buckley <[email protected]> Co-authored-by: Ryan Lucia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into two commits - the shebang stuff might be controversial if CentOS 6 or whatever lacks Python 3.