[build] Check for Python 3 in configure.ac #18625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm also not sure what version of Python 3 we actually require, so 3.5 was arbitrarily chosen because I like the number 5. Someone more familiar with what Red Hat actually ships can hopefully offer a better suggestion. |
I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2).
2ce8239 to
81e6367
Compare
Contributor
Author
|
Looks like we require 3.2 on some of the scripts, so I've set that as the minimum version for now. I can't find anything higher. |
Contributor
Author
|
@monojenkins build failed |
directhex
approved these changes
Jan 31, 2020
akoeplinger
pushed a commit
to monojenkins/mono
that referenced
this pull request
Apr 2, 2020
I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2). (cherry picked from commit 0f47ea5)
akoeplinger
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Force Python 3.x from env in shebang lines * Fix byte/string incompatiblity in Python 3 * Fix locating Python interpreter when it isn't "python" (#18197) Fix locating Python interpreter when it isn't "python" The "python" interpreter is specified by PEP-394. In it, an OS can decide not to ship a "python" executable, and instead only ship python2/3, providing some ambiguity for scripts that are version-neutral, like the one Mono uses. This uses an automake macro to locate a suitable Python, and changes the makefile to use the located Python, whatever it may be. (cherry picked from commit 84221f0) * More disambiguation of Python in makefiles (#18284) (cherry picked from commit b3ce5bf) * [build] Check for Python 3 in configure.ac (#18625) I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2). (cherry picked from commit 0f47ea5) Co-authored-by: Calvin Buckley <[email protected]> Co-authored-by: Ryan Lucia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2).