[2019-12] Force Python 3.x from env in shebang lines #19423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix locating Python interpreter when it isn't "python" The "python" interpreter is specified by PEP-394. In it, an OS can decide not to ship a "python" executable, and instead only ship python2/3, providing some ambiguity for scripts that are version-neutral, like the one Mono uses. This uses an automake macro to locate a suitable Python, and changes the makefile to use the located Python, whatever it may be. (cherry picked from commit 84221f0)
(cherry picked from commit b3ce5bf)
I fear this causing packaging problems, but as-is we require Python 3 for most of our Python files but don't actually check for that in configure. We should be consistent about this. Some projects (notably wasm) also use the Python version detected here, so bumping this will also bump the version used in those cases (a good thing, since there are some known bugs when using the scripts with Python 2). (cherry picked from commit 0f47ea5)
Contributor
|
|
Member
|
@monojenkins build failed |
Member
|
@monojenkins build |
lewurm
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #18284
Backport of #18285 and #18197.
/cc @lewurm @NattyNarwhal