Fix a couple of things in CHANGELOG #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
approved these changes
Jan 24, 2020
Member
Author
|
Ill make the changes you suggested in the PR to |
ewels
reviewed
Jan 25, 2020
Member
ewels
left a comment
There was a problem hiding this comment.
Would be good to put a separate section at the top to explain the changes in the testing for this release..
apeltzer
approved these changes
Jan 26, 2020
Member
apeltzer
left a comment
There was a problem hiding this comment.
That would be great indeed as its a bit more than usual - otherwise looking good :-)
Member
Author
|
Added a line 👍 Let me know if its ok. Now to figuring out why these tests are failing 😅 |
ewels
approved these changes
Jan 27, 2020
Member
ewels
left a comment
There was a problem hiding this comment.
Couple of minor suggested tweaks, but otherwise good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to nf-core/tools!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md