Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI Tests: Force package version to be dev #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewels merged 3 commits into from
Jan 27, 2020
Merged

CI Tests: Force package version to be dev #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
890d940
CI Tests: Force package version to be dev
ewels Jan 27, 2020
103ca14
changelog
ewels Jan 27, 2020
115e680
Drop Travis CI tests for Py2k
ewels Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ sudo: required
language: python
jdk: openjdk8
python:
- '2.7'
- '3.5'
- '3.6'
- '3.7'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* Lint for `Singularity` file [and remove it](https://github.com/nf-core/tools/issues/458)
* Added linting of GitHub actions workflows `linting.yml`, `ci.yml` and `branch.yml`
* Warn if pipeline name contains upper case letters or non alphabetical characters [#85](https://github.com/nf-core/tools/issues/85)
* Make CI tests of lint code pass for releases

### Template pipeline

Expand Down
10 changes: 7 additions & 3 deletions tests/test_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ def pf(wd, path):
# The additional tests passed for releases
ADD_PASS_RELEASE = 1

# The minimal working example expects a development release version
if 'dev' not in nf_core.__version__:
nf_core.__version__ = '{}dev'.format(nf_core.__version__)

class TestLint(unittest.TestCase):
"""Class for lint tests"""

Expand Down Expand Up @@ -127,15 +131,15 @@ def test_config_variable_error(self):
"""Tests that config variable existence test falls over nicely with nextflow can't run"""
bad_lint_obj = nf_core.lint.PipelineLint('/non/existant/path')
bad_lint_obj.check_nextflow_config()

def test_actions_wf_branch_pass(self):
"""Tests that linting for GitHub actions workflow for branch protection works for a good example"""
lint_obj = nf_core.lint.PipelineLint(PATH_WORKING_EXAMPLE)
lint_obj.pipeline_name = 'tools'
lint_obj.check_actions_branch_protection()
expectations = {"failed": 0, "warned": 0, "passed": 2}
self.assess_lint_status(lint_obj, **expectations)

def test_actions_wf_branch_fail(self):
"""Tests that linting for Github actions workflow for branch protection fails for a bad example"""
lint_obj = nf_core.lint.PipelineLint(PATH_FAILING_EXAMPLE)
Expand Down Expand Up @@ -492,4 +496,4 @@ def test_pipeline_name_critical(self):
critical_lint_obj.pipeline_name = 'Tools123'
critical_lint_obj.check_pipeline_name()
expectations = {"failed": 0, "warned": 2, "passed": 0}
self.assess_lint_status(critical_lint_obj, **expectations)
self.assess_lint_status(critical_lint_obj, **expectations)