Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ignored maps in params_used check #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinMenden merged 2 commits into from
May 10, 2021
Merged

ignored maps in params_used check #1062

KevinMenden merged 2 commits into from
May 10, 2021

Conversation

@KevinMenden
Copy link
Contributor

@KevinMenden KevinMenden commented May 10, 2021

This fixes the issue in #1055

Very simple solution by just checking whether the param contains more than one .

In my logic, there can never be more than one dot unless it is a list or something like that. Am I missing something, or can we go with this?

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@KevinMenden KevinMenden requested a review from ewels May 10, 2021 09:13
@KevinMenden KevinMenden added this to the 1.14 milestone May 10, 2021
@KevinMenden KevinMenden linked an issue May 10, 2021 that may be closed by this pull request
params_used lint check complains about all igenomes options #1055
Closed
@codecov
Copy link

codecov bot commented May 10, 2021 •
edited
Loading

Codecov Report

Merging #1062 (7282681) into dev (da71010) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1062      +/-   ##
==========================================
+ Coverage   73.49%   73.52%   +0.03%     
==========================================
  Files          36       36              
  Lines        4396     4401       +5     
==========================================
+ Hits         3231     3236       +5     
  Misses       1165     1165
Impacted Files Coverage Δ
nf_core/lint/params_used.py 91.66% <100.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da71010...7282681. Read the comment docs.

ewels
ewels reviewed May 10, 2021
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@KevinMenden KevinMenden merged commit dd63a4e into nf-core:dev May 10, 2021
@KevinMenden KevinMenden mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewels ewels ewels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.14

Development

Successfully merging this pull request may close these issues.

params_used lint check complains about all igenomes options

2 participants

@KevinMenden @ewels