Return remote params to remove commands #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2042 +/- ##
==========================================
- Coverage 67.60% 67.58% -0.02%
==========================================
Files 43 43
Lines 5572 5572
==========================================
- Hits 3767 3766 -1
- Misses 1805 1806 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Trying to add a test for this now. But it is somehow not working. 🤔 |
Contributor
Author
Which bit is failing? For now it will still only work with nf-core mirrors that also have nf-core as the "org" in the git path. The code to make it work with other repos is in my other branch. |
Contributor
Author
|
Weird error in the CI: |
Contributor
Just a hick-up with the test data repo, rerunning the test fixed it (known issue 😞) |
mashehu
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041
PR checklist
CHANGELOG.mdis updateddocsis updated