copy pre-commit-config.yaml using package_data
#2099
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthdsm
approved these changes
Dec 7, 2022
Member
|
This makes me nervous.. I'm a bit worried that this will cause more problems downstream. Is there really no other way to do this? |
ewels
requested changes
Dec 7, 2022
Member
ewels
left a comment
There was a problem hiding this comment.
Would prefer not to touch the site-packages folder until we have really explored all other possibilities. Very much a last resort.
- Won't be removed on uninstall
- Could clash with other installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2097 copies it to
site-packagesnotnf-core, but that also makes the code run 🙂